PostgreSQL service binding does not get recognised by Quarkus app

[mjurc]

Describe the bug

Since Quarkus 2.15, Quarkus application is unable to bind to PostgreSQL service provided by CrunchyDB.

PostgresCluster used:

apiVersion: postgres-operator.crunchydata.com/v1beta1
kind: PostgresCluster
metadata:
  name: hippo
spec:
  openshift: true
  image: registry.developers.crunchydata.com/crunchydata/crunchy-postgres:ubi8-14.2-1
  postgresVersion: 14
  instances:
    - name: instance1
      dataVolumeClaimSpec:
        accessModes:
          - "ReadWriteOnce"
        resources:
          requests:
            storage: 150Mi
  backups:
    pgbackrest:
      image: registry.developers.crunchydata.com/crunchydata/crunchy-pgbackrest:ubi8-2.38-0
      repos:
        - name: repo1
          volume:
            volumeClaimSpec:
              accessModes:
                - "ReadWriteOnce"
              resources:
                requests:
                  storage: 150Mi

application.properties:

quarkus.kubernetes-service-binding.services.postgresql.api-version=postgres-operator.crunchydata.com/v1beta1
quarkus.kubernetes-service-binding.services.postgresql.kind=PostgresCluster
quarkus.kubernetes-service-binding.services.postgresql.name=hippo

quarkus.datasource.db-kind=postgresql
quarkus.hibernate-orm.database.generation=drop-and-create
quarkus.hibernate-orm.sql-load-script=import.sql

quarkus.openshift.route.expose=true
quarkus.kubernetes.deployment-target=openshift

These settings have worked since Quarkus 2.2.

Expected behavior

Service is bound to Quarkus application and the application launches

Actual behavior

Quarkus fails the service binding, application misses datasource configuration and thus fails to start with

Model classes are defined for the default persistence unit <default> but configured datasource <default> not found: the default EntityManagerFactory will not be created. To solve this, configure the default datasource. Refer to https://quarkus.io/guides/datasource for guidance.

How to Reproduce?

Reproducer is available at https://github.com/quarkus-qe/quarkus-test-suite

1. Login to OpenShift with SBO and CrunchyDB operator
2. check out https://github.com/quarkus-qe/quarkus-test-suite
3. cd service-binding/postrgres-crunchy-classic
4. Run the test to create the PostgresCluster, deploy the application and run crud operations on it: mvn clean verify -Dopenshift

To run with Quarkus that worked with this SB, you can run mvn clean verify -Dopenshift -Dquarkus.platform.version=2.14.3.Final

To manually deploy the PostgresCluster and the application, run the following:

oc apply -f ./src/test/resources/pg-cluster.yml
# wait for PostgresCluster
oc -n ${YOUR_NAMESPACE} wait --for condition=Ready --timeout=300s pods --all
# build + deploy app in OCP
mvn clean install -Dquarkus.kubernetes-client.trust-certs=true -Dquarkus.kubernetes.deploy=true

Output of uname -a or ver

Linux tigris 6.1.7-200.fc37.x86_64 #1 SMP PREEMPT_DYNAMIC Wed Jan 18 17:11:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk version "17.0.5" 2022-10-18

GraalVM version (if different from Java)

No response

Quarkus version or git rev

since 2.15.0

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.5 (Red Hat 3.8.5-3)

Additional information

This also fails for reactive Hibernate - for the reproducer, see https://github.com/quarkus-qe/quarkus-test-suite/tree/main/service-binding/postgresql-crunchy-reactive.

The application manages to boot there, but it fails when it tries to access the datasource with bogus URL:

18:29:46,010 INFO  [app] 17:29:40,998 HR000057: Failed to execute statement [select todo0_.id as id1_0_0_, todo0_.completed as complete2_0_0_, todo0_.title as title3_0_0_ from Todo todo0_ where todo0_.id=$1]: could not load an entity: [io.quarkus.ts.sb.reactive.Todo#1]: java.util.concurrent.CompletionException: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:5432

[quarkus-bot]

/cc @Sgitario (kubernetes), @geoand (kubernetes,openshift), @iocanel (kubernetes,openshift)

[Sgitario]

I'm having a look into this issue

[Sgitario]

@mjurc the traces you shared seem to be caused because the Service Binding Operator is not installed. If you install it, then you will reach to the actual issue:

 --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ 
 -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   
--\___\_\____/_/ |_/_/|_/_/|_|\____/___/   
2023-02-07 12:39:55,703 WARN  [io.agr.pool] (main) Datasource '<default>': Driver does not support the provided URL: postgresql://hippo:f1%3Cm5liNIB%3CbwpWQMi+.zjA%[email protected]:5432/hippo
2023-02-07 12:39:55,953 WARN  [io.agr.pool] (agroal-11) Datasource '<default>': Driver does not support the provided URL: postgresql://hippo:f1%3Cm5liNIB%3CbwpWQMi+.zjA%[email protected]:5432/hippo
2023-02-07 12:39:55,954 WARN  [org.hib.eng.jdb.env.int.JdbcEnvironmentInitiator] (JPA Startup Thread) HHH000342: Could not obtain connection to query metadata: java.sql.SQLException: Driver does not support the provided URL: postgresql://hippo:f1%3Cm5liNIB%3CbwpWQMi+.zjA%[email protected]:5432/hippo

And this issue is caused by the changes in #29702 because the crunchy operator does not provide the jdbc-url property, but the uri property. So, after the changes in the mentioned pull request, the uri property is used, but this property does not have the JDBC prefix and hence it's not working.

I will address this issue by:

• reading the jdbc-uri property which the crunchy operator is providing
• plus, in case the uri property does not follow the expected format, we do not use it.
  wdyt? @geoand

[geoand]

👍🏼

Let's also add proper warning messages in cases we encounter unexpected values

[mjurc]

@geoand @Sgitario We've got back to this issue now. The fix didn't work, and this is certainly not an issue of cluster setup - it works on 2.13.5.Final and early 2.14 versions too.

New issue: #32773

[geoand]

Okay. @Sgitario can you have a look or do you want me to?

[Sgitario]

Okay. @Sgitario can you have a look or do you want me to?

I'm having a look.

[geoand]

🙏🏼

[EE1234EE]

Hey folks,

any updates to this issue? I followed the quickstart guide crunchy operator. Quarkus Version 3.3.0 and still mentioned error.