Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.15.2.Final breaks command mode with main class extends from QuarkusApplication in kotlin #30190

Closed
mschorsch opened this issue Jan 5, 2023 · 7 comments · Fixed by #30200
Closed
Labels
area/kotlin kind/bug Something isn't working
Milestone

Comments

@mschorsch
Copy link
Contributor

mschorsch commented Jan 5, 2023

Describe the bug

Same error as in #30054 .

import io.quarkus.runtime.QuarkusApplication
import io.quarkus.runtime.annotations.QuarkusMain

@QuarkusMain
class MainCLI : QuarkusApplication {

    @Throws(Exception::class)
    override fun run(vararg args: String): Int {
        return 0
    }
}
...
[ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:2.15.2.Final:build (default) on project code-with-quarkus: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[ERROR] 	[error]: Build step io.quarkus.deployment.steps.MainClassBuildStep#mainClassBuildStep threw an exception: java.lang.IllegalArgumentException: The supplied 'main-class' value of 'org.acme.MainCLIKt' does not correspond to either a fully qualified class name or a matching 'name' field of one of the '@QuarkusMain' annotations
...

How to Reproduce?

code-with-quarkus.zip

./mvnw clean install

Output of java -version

Java 17

Quarkus version or git rev

2.15.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Maven

@mschorsch mschorsch added the kind/bug Something isn't working label Jan 5, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 5, 2023

/cc @evanchooly(kotlin), @geoand(kotlin)

geoand added a commit to geoand/quarkus that referenced this issue Jan 5, 2023
Fixes: quarkusio#30190

Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication
as a superclass)
@geoand
Copy link
Contributor

geoand commented Jan 5, 2023

Ouch, I really messed that one up 🤦🏼

#30200 should properly take care of it

geoand added a commit to geoand/quarkus that referenced this issue Jan 5, 2023
Fixes: quarkusio#30190

Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication
as a superclass)
geoand added a commit that referenced this issue Jan 5, 2023
Ensure that Kotlin implementation of QuarkusApplication works properly
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Jan 5, 2023
@mschorsch
Copy link
Contributor Author

Thanks @geoand

@mschorsch
Copy link
Contributor Author

@gsmet This issue prevents us from upgrading to 2.15. Can we backport this issue to 2.15.3.Final.

@geoand
Copy link
Contributor

geoand commented Jan 6, 2023

That's the plan

@mschorsch
Copy link
Contributor Author

Thanks

@geoand
Copy link
Contributor

geoand commented Jan 6, 2023

🙏

@gsmet gsmet modified the milestones: 2.16 - main, 2.15.3.Final Jan 9, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 9, 2023
Fixes: quarkusio#30190

Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication
as a superclass)

(cherry picked from commit d5fb7fc)
benkard added a commit to benkard/mulkcms2 that referenced this issue Jan 14, 2023
This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `2.15.2.Final` -> `2.15.3.Final` |
| [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `2.15.2.Final` -> `2.15.3.Final` |

---

### Release Notes

<details>
<summary>quarkusio/quarkus</summary>

### [`v2.15.3.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.15.3.Final)

[Compare Source](quarkusio/quarkus@2.15.2.Final...2.15.3.Final)

##### Complete changelog

-   [#&#8203;30255](quarkusio/quarkus#30255) - Introduce a JSON Stream parser for the reactive rest client
-   [#&#8203;30242](quarkusio/quarkus#30242) - Throw an IllegalStateException with basic info about the provider that failed to provide a resource
-   [#&#8203;30227](quarkusio/quarkus#30227) - SmallRye GraphQL 1.9.1/2.0.1 + config property to control Federation
-   [#&#8203;30218](quarkusio/quarkus#30218) - OIDC documentation fixes
-   [#&#8203;30200](quarkusio/quarkus#30200) - Ensure that Kotlin implementation of QuarkusApplication works properly
-   [#&#8203;30195](quarkusio/quarkus#30195) - Log graphql.execution.AbortExecutionException when it occurs
-   [#&#8203;30190](quarkusio/quarkus#30190) - 2.15.2.Final breaks command mode with main class extends from QuarkusApplication in kotlin
-   [#&#8203;30187](quarkusio/quarkus#30187) - Bump xstream from 1.4.19 to 1.4.20
-   [#&#8203;30183](quarkusio/quarkus#30183) - Fixing typos in security overview doc
-   [#&#8203;30177](quarkusio/quarkus#30177) - Properly handle SSE comments in RESTEasy Reactive client and server code
-   [#&#8203;30172](quarkusio/quarkus#30172) - Codestarts - Fix flattening of log levels
-   [#&#8203;30169](quarkusio/quarkus#30169) - NullPointerException when sending SSE with comment only
-   [#&#8203;30161](quarkusio/quarkus#30161) - Align behavior for getDeferredIdentity and getIdentity in TestIdentityAssociation
-   [#&#8203;30160](quarkusio/quarkus#30160) - Different behavior in TestIdentityAssociation for getDeferredIdentity and getIdentity
-   [#&#8203;30157](quarkusio/quarkus#30157) - Gradle quarkusDev: don't use test classes dir for app classes
-   [#&#8203;30155](quarkusio/quarkus#30155) - Show how to verify smallrye-jwt issuer in a shared network
-   [#&#8203;30154](quarkusio/quarkus#30154) - Remove remaining references to javax classes
-   [#&#8203;30152](quarkusio/quarkus#30152) - Improve error handling of AbortExecutionException in smallrye-graphql extension
-   [#&#8203;30146](quarkusio/quarkus#30146) - Properly segregate Json MessageBodyReader/Writer classes for server and client
-   [#&#8203;30145](quarkusio/quarkus#30145) - GraphQL federation directives, which allow multiple values, do not match Apollo contract
-   [#&#8203;30142](quarkusio/quarkus#30142) - When disabling name and version for label selectod in k8s, don't remove from labels
-   [#&#8203;30138](quarkusio/quarkus#30138) - Keycloak Dev Services
-   [#&#8203;30132](quarkusio/quarkus#30132) - Register REST Client body parameters for reflection
-   [#&#8203;30119](quarkusio/quarkus#30119) - Enable/disable GraphQL Federation automatically (+ add a config property for it)
-   [#&#8203;30100](quarkusio/quarkus#30100) - Setting `add-version-to-label-selectors: false` removes the app.kubernetes.io/version label
-   [#&#8203;30078](quarkusio/quarkus#30078) - Quarkus Kotlin Native Reactive REST Client not working properly
-   [#&#8203;30061](quarkusio/quarkus#30061) - Adding Kotlin Tests Breaks Kotlin/Java project
-   [#&#8203;30044](quarkusio/quarkus#30044) - Resteasy Reactive Rest Client fails to re-construct large chunks of streamed json (stream+json) and fails deserialization
-   [#&#8203;29998](quarkusio/quarkus#29998) - Bump to smallrye-config 2.13.1
-   [#&#8203;29918](quarkusio/quarkus#29918) - smallrye-config: Converter<Int> throws IllegalStateException
-   [#&#8203;29609](quarkusio/quarkus#29609) - Remove Reflection replacements, now supported by GraalVM

</details>

<details>
<summary>quarkusio/quarkus-platform</summary>

### [`v2.15.3.Final`](quarkusio/quarkus-platform@2.15.2.Final...2.15.3.Final)

[Compare Source](quarkusio/quarkus-platform@2.15.2.Final...2.15.3.Final)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
ebullient pushed a commit to maxandersen/quarkus that referenced this issue Jan 24, 2023
Fixes: quarkusio#30190

Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication
as a superclass)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kotlin kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants