-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel LateBoundSampler
logs warning if using Liquibase and JDBC instrumentation
#29987
Comments
/cc @andrejpetras(liquibase), @geoand(liquibase), @gsmet(liquibase) |
I think this has more to do with tracing, cc @brunobat @radcortez |
LateBoundSampler
logs warning if using Liquibase and SQL instrumentationLateBoundSampler
logs warning if using Liquibase and JDBC instrumentation
Hi @famod can you please provide a reproducer? |
Hi @brunobat, I added a reproducer. AFAICS, this issue is not specific to dev mode, but it was the fastest way to reproduce. The reproducer is basically identical to the official liquibase quickstart, only with two added OTel deps and two additional config settings. |
Thanks very much @famod |
In more recent versions of Quarkus, the warning is always displayed when OpenTelemetry is used (regardless of what other extension or configuration are used). I am looking into a fix |
This is now done entirely in a CDI producer method which is then fully initialized when OpenTelemetry autoconfigures itself Fixes: quarkusio#29987
Here it is. |
This is now done entirely in a CDI producer method which is then fully initialized when OpenTelemetry autoconfigures itself Fixes: quarkusio#29987
This is now done entirely in a CDI producer method which is then fully initialized when OpenTelemetry autoconfigures itself Fixes: quarkusio#29987 (which with newer Quarkus versions is even more problematic)
This is now done entirely in a CDI producer method which is then fully initialized when OpenTelemetry autoconfigures itself Fixes: quarkusio#29987 (which with newer Quarkus versions is even more problematic)
Properly construct instance of LateBoundBatchSpanProcessor
Describe the bug
I was irritated by the following message very early during boot and started digging:
Turns out that when you have JDBC instrumentation and Liquibase migration at startup (using the same datasource and OTEL driver as the rest of the app), the sampler is apparently not set yet, hence the warning.
Expected behavior
No warning from OTEL extension, even if using "startup time features" such as the liquibase extension.
Actual behavior
Warning logged
How to Reproduce?
liquibase-quickstart-with-otel.zip
mvn quarkus:dev
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.15.0.Final
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
LateBoundBatchSpanProcessor
issues a similar warning (if otlp export is not disabled).Of course it doesn't make much sense to trace liquibase JDBC operations, but simply using the regular app datasource is the default setup for simple cases.
The text was updated successfully, but these errors were encountered: