Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Javadoc Plugin fails because of a Quarkus module name #29719

Closed
triceo opened this issue Dec 7, 2022 · 2 comments · Fixed by #30807
Closed

Maven Javadoc Plugin fails because of a Quarkus module name #29719

triceo opened this issue Dec 7, 2022 · 2 comments · Fixed by #30807
Labels
area/maven kind/bug Something isn't working
Milestone

Comments

@triceo
Copy link
Contributor

triceo commented Dec 7, 2022

Describe the bug

When upgrading Maven Javadoc Plugin to 3.4.1, we get the following exception:

Execution build-javadoc-jar of goal org.apache.maven.plugins:maven-javadoc-plugin:3.4.1:jar failed: Unable to derive module descriptor for /var/home/triceo/.m2/repository/io/quarkus/quarkus-class-change-agent/2.14.1.Final/quarkus-class-change-agent-2.14.1.Final.jar: quarkus.class.change.agent: Invalid module name: 'class' is not a Java identifier

It appears that quarkus.class.change.agent is not a valid JPMS module name, note the class keyword. And this transitively breaks our build.

Expected behavior

Quarkus does not transitively break downstream projects' Javadoc generation.

Actual behavior

An exception is thrown during Javadoc generation.

How to Reproduce?

Build this PR:
https://github.com/kiegroup/optaplanner/pull/2412

See exception in optaplanner-quarkus-deployment module.

Output of uname -a or ver

Linux degrasse 6.0.10-300.fc37.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Nov 26 16:55:13 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk version "17.0.4" 2022-07-19 OpenJDK Runtime Environment Temurin-17.0.4+8 (build 17.0.4+8) OpenJDK 64-Bit Server VM Temurin-17.0.4+8 (build 17.0.4+8, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.14.2

Build tool (ie. output of mvnw --version or gradlew --version)

Maven home: /home/triceo/.sdkman/candidates/maven/current Java version: 17.0.4, vendor: Eclipse Adoptium, runtime: /var/home/triceo/.sdkman/candidates/java/17.0.4-tem Default locale: cs_CZ, platform encoding: UTF-8 OS name: "linux", version: "6.0.10-300.fc37.x86_64", arch: "amd64", family: "unix"

Additional information

No response

@triceo triceo added the kind/bug Something isn't working label Dec 7, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2022

/cc @quarkusio/devtools

@famod
Copy link
Member

famod commented Dec 7, 2022

Related: #28919

@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 3, 2023
triceo added a commit to triceo/quarkus that referenced this issue Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maven kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants