-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenShift deployment don't generate command when arguments are provided #29451
Labels
Comments
This is an issue with the default images "ubi8/openjdk-11" and "ubi8/openjdk-17" (also for the new "ubi9" images). |
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Dec 7, 2022
The default base image for OpenShift s2i builds: ubi8/openjdk-11 or ubi8/openjdk-17 needs the Java command when there are arguments. Therefore, let's generate always the command when using these images (the old ubi8 and ubi9 images) and also in Native mode. Fix quarkusio#29451 Relates quarkusio#29642
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Dec 7, 2022
The default base image for OpenShift s2i builds: ubi8/openjdk-11 or ubi8/openjdk-17 needs the Java command when there are arguments. Therefore, let's generate always the command when using these images (the old ubi8 and ubi9 images) and also in Native mode. Fix quarkusio#29451 Fix quarkusio#29642
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this issue
Dec 7, 2022
The default base image for OpenShift s2i builds: ubi8/openjdk-11 or ubi8/openjdk-17 needs the Java command when there are arguments. Therefore, let's generate always the command when using these images (the old ubi8 and ubi9 images) and also in Native mode. Fix quarkusio#29451 Fix quarkusio#29642
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When
quarkus.openshift.arguments
are provided, first one is used as command is not generated. I think the behavior was introduced by #27733, but the PR description says The command may still be generated if the user provides arguments without command.Expected behavior
One of:
Actual behavior
Container fails to start as first argument is used to start the app.
Error: container create failed: time="2022-11-23T15:50:25Z" level=error msg="runc create failed: unable to start container process: exec: "ARG1": executable file not found in $PATH"
How to Reproduce?
Reproducer:
Steps to reproduce the behavior:
quarkus create app org.acme:openshift-quickstart \ --extension='resteasy-reactive,openshift'
cd openshift-quickstart
quarkus build -Dquarkus.kubernetes.deploy=true -Dquarkus.kubernetes-client.trust-certs=true -Dquarkus.openshift.arguments="ARG1,ARG2" -Dquarkus.platform.version=2.13.0.Final -DskipTests -DskipITs
(NOTE: same happens when you use-Dnative
)oc get pod
Alternatively:
git clone https://github.com/quarkus-qe/quarkus-test-suite.git
cd quarkus-test-suite/lifecycle-application
mvn clean verify -Dopenshift -Dit.test=OpenShiftLifecycleApplicationIT
(NOTE: same happens when you use-Dnative
)oc get pod
Output of
uname -a
orver
Linux
Output of
java -version
openjdk version "17.0.5" 2022-10-18
GraalVM version (if different from Java)
GraalVM CE 22.3.0
Quarkus version or git rev
2.13.0 +, 2.14, 999-SNAPSHOT
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.8.6
Additional information
No response
The text was updated successfully, but these errors were encountered: