Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ClientHeaderParam is ignored when ClientHeadersFactory impl is used #28738

Closed
lthasle opened this issue Oct 21, 2022 · 6 comments · Fixed by #28845
Closed

@ClientHeaderParam is ignored when ClientHeadersFactory impl is used #28738

lthasle opened this issue Oct 21, 2022 · 6 comments · Fixed by #28845
Labels
area/rest-client kind/bug Something isn't working
Milestone

Comments

@lthasle
Copy link

lthasle commented Oct 21, 2022

Describe the bug

Adding @ClientHeaderParam to a resteasy reactive interface don't work,
ie. the key and value is NOT added to the http request.

https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/.40ClientHeaderParam.20resteasy.20reactive

Expected behavior

ClientHeaderParam should not be ignored

Actual behavior

The usage of ClientHeaderParam is ignored

How to Reproduce?

Run the provided test.
Verify the logging

with the usage of: ClientHeadersFactory

[org.jbo.res.rea.cli.log.DefaultClientLogger] (vert.x-eventloop-thread-0) Request: GET http://localhost:8081/my/ep2/ Headers[myKey=myValue User-Agent=Resteasy Reactive Client], Empty body

without the usage of: ClientHeadersFactory

[org.jbo.res.rea.cli.log.DefaultClientLogger] (vert.x-eventloop-thread-1) Request: GET http://localhost:8081/my/ep2/ Headers[lostKey=lostValue User-Agent=Resteasy Reactive Client], Empty body
rest-client-reactive-quickstart15.zip

Output of uname -a or ver

Linux hty80028.sb1a.sparebank1.no 4.18.0-372.26.1.el8_6.x86_64 #1 SMP Sat Aug 27 02:44:20 EDT 2022 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk version "17.0.4.1" 2022-08-12 OpenJDK Runtime Environment Temurin-17.0.4.1+1 (build 17.0.4.1+1) OpenJDK 64-Bit Server VM Temurin-17.0.4.1+1 (build 17.0.4.1+1, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.13.3.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /home/sb1a.sparebank1.no/a11882/opt/maven Java version: 17.0.4.1, vendor: Eclipse Adoptium, runtime: /home/sb1a.sparebank1.no/a11882/opt/jdk-17.0.4.1_1 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.18.0-372.26.1.el8_6.x86_64", arch: "amd64", family: "unix"

Additional information

No response

@lthasle lthasle added the kind/bug Something isn't working label Oct 21, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 21, 2022

You added a link to a Zulip discussion, please make sure the description of the issue is comprehensive and doesn't require accessing Zulip.

This message is automatically generated by a bot.

@geoand
Copy link
Contributor

geoand commented Oct 21, 2022

I am not sure what the proper behavior is here honestly...

@Sgitario WDYT?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 21, 2022

/cc @Sgitario, @cescoffier

@Sgitario
Copy link
Contributor

I am not sure what the proper behavior is here honestly...

@Sgitario WDYT?

I think this is definitely a bug. Actually, the documentation introduces a very similar example with the usage of @RegisterClientHeaders and @ClientHeaderParam altogether: https://quarkus.io/guides/rest-client-reactive#custom-headers-support

@geoand
Copy link
Contributor

geoand commented Oct 26, 2022

Do you want to take a look at it @Sgitario or should I?

@Sgitario
Copy link
Contributor

Do you want to take a look at it @Sgitario or should I?

I will :D

@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Oct 26, 2022
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.0.Final Oct 28, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 28, 2022
@gsmet gsmet modified the milestones: 2.14.0.Final, 2.13.4.Final Oct 31, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 31, 2022
zakkak pushed a commit to zakkak/quarkus that referenced this issue Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest-client kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants