-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CookieParam is not correctly handled by the default Resteasy Reactive converter #28453
Comments
/cc @FroMage, @geoand, @stuartwdouglas |
#28464 takes care of the issue. Seems weird that we never encountered a case of using |
Yeah, interesting, I suppose it shows manually dealing with cookies is done rarely |
Very likely! |
geoand
added a commit
that referenced
this issue
Oct 10, 2022
Ensure that JAX-RS Cookie parameter type is usable in Resource methods
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Oct 10, 2022
Fixes: quarkusio#28453 (cherry picked from commit ac731a2)
Well, cookies work, but they're usually deserialised to |
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this issue
Oct 16, 2022
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this issue
Oct 16, 2022
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this issue
Oct 16, 2022
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this issue
Oct 17, 2022
tmihalac
pushed a commit
to tmihalac/quarkus
that referenced
this issue
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If I have
@CookieParam("csrftoken") Cookie token
thenCookie token
will have itsname
set to the value of thecsrftoken
cookie and the value will remain empty.I'm sorry if I got it wrong, but after tracing the request and debugging the test endpoint it does look like the case.
Expected behavior
Given
@CookieParam("csrftoken") Cookie token
, theCookie
name should be set tocsrftoken
, and value to the actual cookie valueActual behavior
No response
How to Reproduce?
Check out #28383, go to
integration-tests/csrf-reactive
, domvn test -Dtest=CsrfReactiveTest#testCsrfTokenMultipart
, have a breakpoint inTestResource#postCsrfTokenMulltipart
to confirmOutput of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: