Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5005 port is not freed in devmode during the restart #28187

Closed
sberyozkin opened this issue Sep 25, 2022 · 2 comments · Fixed by #28620
Closed

5005 port is not freed in devmode during the restart #28187

sberyozkin opened this issue Sep 25, 2022 · 2 comments · Fixed by #28620
Labels
area/devmode kind/bug Something isn't working
Milestone

Comments

@sberyozkin
Copy link
Member

Describe the bug

Sometimes, in devmode, after modifying pom.xml by adding a new dependency, an error message is displayed during the restart that 5005 is busy and no debug mode will be activated

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

Start quarkus-quickstarts/hibernate-orm-panache-quickstart in devmode, then add quarkus-oidc to pom.xml and the error will be displayed in the console that 5005 is busy

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@sberyozkin sberyozkin added the kind/bug Something isn't working label Sep 25, 2022
@sberyozkin sberyozkin changed the title 5005 port sometimes is not freed in devmode during the restart 5005 port is not freed in devmode during the restart Sep 25, 2022
@sberyozkin
Copy link
Member Author

CC @stuartwdouglas, Let me know please where it can be fixed, I can try to handle it or open a PR if you can find a few mins

@stuartwdouglas
Copy link
Member

It probably just needs a sleep + busy wait loop for a second or two to wait for the socket to be released in QuarkusDevModeLauncher. Basically if the socket was ok on the first launch, it should be ok on the second so re-run the checking code in a loop with a small sleep util it either works or some other timeout.

michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Oct 15, 2022
michalvavrik added a commit to michalvavrik/quarkus that referenced this issue Oct 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 16, 2022
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 16, 2022
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 16, 2022
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 16, 2022
igorregis pushed a commit to igorregis/quarkus that referenced this issue Oct 17, 2022
Liuigi pushed a commit to Liuigi/quarkus that referenced this issue Oct 17, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.3.Final Oct 17, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 17, 2022
tmihalac pushed a commit to tmihalac/quarkus that referenced this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devmode kind/bug Something isn't working
Projects
None yet
3 participants