Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BeanManger#isPassivatingScope #2721

Closed
tandraschko opened this issue Jun 5, 2019 · 2 comments
Closed

Implement BeanManger#isPassivatingScope #2721

tandraschko opened this issue Jun 5, 2019 · 2 comments
Labels
kind/enhancement New feature or request
Milestone
0.17.0

Comments

@tandraschko
Copy link
Contributor

tandraschko commented Jun 5, 2019 •
edited
Loading

Some frameworks like JSF or DeltaSpike use bm#isPassivatingScope to check if the scope is passivating, and based on this value, the CustomContext#get implementation checks the bean instanceof PassivationCapable (https://github.com/apache/myfaces/blob/4619df600ba130f6e6f8d26d2e7c960d2d36f0de/impl/src/main/java/org/apache/myfaces/cdi/util/AbstractContext.java#L46)

If quarkus would implement isPassivatingScope with "return false" per default, such frameworks as MyFaces don't need to introduce config flags.
It maybe be a bit nicer as throwing a UnsupportedOperationException.

WDYT @mkouba?
@tandraschko tandraschko added the kind/enhancement New feature or request label Jun 5, 2019
@tandraschko tandraschko mentioned this issue Jun 5, 2019
Closed
@mkouba
Copy link
Contributor

mkouba commented Jun 5, 2019

isPassivatingScope() returning false is probably reasonable because passivation is intentionally ignored ATM. Would you care to send a PR?

tandraschko added a commit to tandraschko/quarkus that referenced this issue Jun 10, 2019
@tandraschko
quarkusio#2721 - Implement BeanManger#isPassivatingScope
4fa6dd2
@tandraschko tandraschko mentioned this issue Jun 10, 2019
Merged
@tandraschko
Copy link
Contributor Author

@mkouba created!

cescoffier added a commit that referenced this issue Jun 11, 2019
@cescoffier
Merge pull request #2772 from tandraschko/master
3702128 
#2721 - Implement BeanManger#isPassivatingScope
@cescoffier cescoffier added this to the 0.17.0 milestone Jun 11, 2019
mswiderski pushed a commit to mswiderski/quarkus that referenced this issue Jun 13, 2019
@tandraschko @mswiderski
quarkusio#2721 - Implement BeanManger#isPassivatingScope
6658b56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
3 participants
@cescoffier @mkouba @tandraschko