Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Kafka-based integration tests from main integration tests #2691

Closed
gunnarmorling opened this issue Jun 2, 2019 · 0 comments
Closed

Separate Kafka-based integration tests from main integration tests #2691

gunnarmorling opened this issue Jun 2, 2019 · 0 comments
Labels
kind/enhancement New feature or request
Milestone
0.17.0

Comments

@gunnarmorling
Copy link
Contributor

The Kafka-based integration tests spin up a Kafka node which isn't needed for the majority of tests in integration-tests main. On the other hand, there's an H2 database started up, which isn't needed in the Kafka tests. Separating the tests into two module will make running individual tests quicker, e.g. from within the IDE. I'll send a PR an a bit.
@gunnarmorling gunnarmorling added the kind/enhancement New feature or request label Jun 2, 2019
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 2, 2019
@gunnarmorling
quarkusio#2691 Extracting Kafka-based integration tests into their ow…
292ef20 
…n module
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 2, 2019
@gunnarmorling
quarkusio#2691 Extracting Kafka-based integration tests into their ow…
5360b09 
…n module
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 2, 2019
@gunnarmorling
quarkusio#2691 Removing call to deprecated method
34fe79c
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 2, 2019
@gunnarmorling
quarkusio#2691 Removing call to deprecated method
8448f3f
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 3, 2019
@gunnarmorling
quarkusio#2691 Addressing review remarks
b0c1239
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 3, 2019
@gunnarmorling
quarkusio#2691 Extracting Kafka-based integration tests into their ow…
1f5a422 
…n module
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 3, 2019
@gunnarmorling
quarkusio#2691 Removing call to deprecated method
22084a2
cescoffier added a commit that referenced this issue Jun 4, 2019
@cescoffier
Merge pull request #2692 from gunnarmorling/2691_extract-kafka-its
29bfe5a 
#2691 Extracting Kafka-based integration tests into their own module
@gsmet gsmet added this to the 0.17.0 milestone Jun 4, 2019
@gsmet gsmet closed this as completed Jun 4, 2019
gunnarmorling added a commit to gunnarmorling/quarkus that referenced this issue Jun 4, 2019
@gunnarmorling
quarkusio#2691 Moving integration tests to "kafka" package
c7bc691
@gunnarmorling gunnarmorling mentioned this issue Jun 4, 2019
Merged
mswiderski pushed a commit to mswiderski/quarkus that referenced this issue Jun 13, 2019
@gunnarmorling @mswiderski
quarkusio#2691 Moving integration tests to "kafka" package
a14f456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@gunnarmorling @gsmet