Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTEasy Reactive - support binary content streaming with header control #26523

Closed
huw0 opened this issue Jul 2, 2022 · 5 comments · Fixed by #33197
Closed

RESTEasy Reactive - support binary content streaming with header control #26523

huw0 opened this issue Jul 2, 2022 · 5 comments · Fixed by #33197
Labels
area/rest kind/enhancement New feature or request
Milestone

Comments

@huw0
Copy link

huw0 commented Jul 2, 2022

Description

Summary - Quarkus RESTEasy Reactive should natively support Uni<RestResponse<Multi<byte[]>>>

Description

I am using the solution outlined here for streaming binary content using Multi<byte[]>.

It is essential that the response and headers can be set dynamically. For example Content-Type and ETag. The latter allows dynamically sending 304 Not Modified on any later duplicate requests.

There has been discussion about this on Zulip.

Implementation ideas

No response

@huw0 huw0 added the kind/enhancement New feature or request label Jul 2, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 2, 2022

You added a link to a Zulip discussion, please make sure the description of the issue is comprehensive and doesn't require accessing Zulip.

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/rest label Jul 2, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 2, 2022

/cc @FroMage, @geoand, @stuartwdouglas

@geoand
Copy link
Contributor

geoand commented Jul 4, 2022

Thanks for reporting.

I would say that supporting Uni<RestResponse<Multi<byte[]>>> is not ideal as that type is very complicated and not very intuitive...

@FroMage
Copy link
Member

FroMage commented Jul 20, 2022

Well, the type is far from ideal, for sure. But I can think of cases where this is required, for example if the header data comes from the DB (size, file name) and the content is then streamed from FS or online storage or whatever. So unfortunately it makes a lot of sense :(

@geoand
Copy link
Contributor

geoand commented May 9, 2023

#33197 introduces RestMulti which can be used to control the response headers and status code

geoand added a commit to geoand/quarkus that referenced this issue May 9, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 10, 2023
manofthepeace pushed a commit to manofthepeace/quarkus that referenced this issue May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants