Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@NameBinding not working for ServerResponseFilter #26088

Closed
romilpunetha opened this issue Jun 13, 2022 · 2 comments · Fixed by #26110
Closed

@NameBinding not working for ServerResponseFilter #26088

romilpunetha opened this issue Jun 13, 2022 · 2 comments · Fixed by #26110
Assignees
Labels
area/rest kind/bug Something isn't working
Milestone

Comments

@romilpunetha
Copy link

Describe the bug

A ServerResponseFilter is always executed even when it is constrained by a @NameBinding annotation and the annotation is not used.

In this example, the annotation alters the response context status code. However, the annotation is not used in the resource, yet the status code changes.

Expected behavior

The response filter should not be applied since the @namebinding annotation is not used.

Actual behavior

The filter is applied.

How to Reproduce?

Run the test in the following repo:

https://github.com/romilpunetha/quarkus-test-filter

Output of uname -a or ver

Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:01 PDT 2021; root:xnu-8019.41.5~1/RELEASE_ARM64_T6000 arm64

Output of java -version

openjdk version "17.0.2" 2022-01-18

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.9.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Maven home: /opt/homebrew/Cellar/maven/3.8.5/libexec

Additional information

No response

@romilpunetha romilpunetha added the kind/bug Something isn't working label Jun 13, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 14, 2022

/cc @FroMage, @stuartwdouglas

@geoand
Copy link
Contributor

geoand commented Jun 14, 2022

Thanks for reporting. #26110 takes care of the issue

geoand added a commit that referenced this issue Jun 14, 2022
Ensure that @ServerResponseFilter honors @namebinding
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 14, 2022
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.0.Final Jun 15, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants