@Rollback
annotation is JTA-specific: should be reusable for Hibernate Reactive with Panache
#24500
Labels
area/hibernate-orm
Hibernate ORM
area/hibernate-reactive
Hibernate Reactive
area/panache
area/persistence
OBSOLETE, DO NOT USE
kind/enhancement
New feature or request
Milestone
Description
In #22202 I screwed up and should have anticipated that we'd need that annotation also for HR.
It's acceptable that we have own own
@ReactiveTransactional
annotation because we don't want the ORM (actually JTA) and HR to walk on each other's feet. But it's not acceptable to ask users to decorate their exceptions with both@Rollback
(from JTA) and@ReactiveRollback
(from HR/Panache) because that adds two dependencies "just in case" the exception user uses ORM or HR.So I vote to move that exception to a new extension
quarkus-transactions
that only has a runtime module containing the single class@Rollback
, and zero dependency.Not sure about the name, should it be plural or what? Should we add the annotation some other place, perhaps in an existing module such as
quarkus-hibernate-orm
which is after all, included byhibernate-reactive
?@Sanne or @DavideD would that be better/acceptable do you think?
Sorry about the urgency, but I think it'd be nice to figure this one out before we release 2.8, which currently has the new annotation, before it starts being used.
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: