Quarkus testing with `@ParameterizedTest` broken with Java 17 + 18 (xstream) #24492

snazy · 2022-03-23T09:32:52Z

Describe the bug

The following exception happens during tests using @QuarkusTest with Java 17 + 18.

The failing test case is a @ParameterizedTest with a @MethodSource that returns a Stream of objects that contain List instances created by Arrays.asList() - hence the java.util.Collections$UnmodifiableCollection.

Looks like it's not a direct fault of Quarkus, but xsteam not able to deal with those objects.

Adding --add-opens=java.base/java.util=ALL-UNNAMED does not help.

com.thoughtworks.xstream.converters.ConversionException: 
No converter available
---- Debugging information ----
message             : No converter available
type                : java.util.Collections$UnmodifiableRandomAccessList
converter           : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
message[1]          : Unable to make field private static final long java.util.Collections$UnmodifiableCollection.serialVersionUID accessible: module java.base does not "opens java.util" to unnamed module @7f1dd5e7
-------------------------------
	at com.thoughtworks.xstream.core.DefaultConverterLookup.lookupConverterForType(DefaultConverterLookup.java:88)
	at com.thoughtworks.xstream.XStream$1.lookupConverterForType(XStream.java:478)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:49)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:83)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshallField(AbstractReflectionConverter.java:270)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter$2.writeField(AbstractReflectionConverter.java:174)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.doMarshal(AbstractReflectionConverter.java:262)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshal(AbstractReflectionConverter.java:90)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:68)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:59)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:83)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshallField(AbstractReflectionConverter.java:270)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter$2.writeField(AbstractReflectionConverter.java:174)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.doMarshal(AbstractReflectionConverter.java:262)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshal(AbstractReflectionConverter.java:90)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:68)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:59)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:83)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshallField(AbstractReflectionConverter.java:270)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter$2.writeField(AbstractReflectionConverter.java:174)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.doMarshal(AbstractReflectionConverter.java:262)
	at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.marshal(AbstractReflectionConverter.java:90)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:68)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:59)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:44)
	at com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:83)
	at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1266)
	at com.thoughtworks.xstream.XStream.marshal(XStream.java:1255)
	at com.thoughtworks.xstream.XStream.toXML(XStream.java:1228)
	at com.thoughtworks.xstream.XStream.toXML(XStream.java:1215)
	at io.quarkus.test.junit.internal.XStreamDeepClone.doClone(XStreamDeepClone.java:49)
	at io.quarkus.test.junit.internal.XStreamDeepClone.clone(XStreamDeepClone.java:35)
	at io.quarkus.test.junit.internal.SerializationWithXStreamFallbackDeepClone.clone(SerializationWithXStreamFallbackDeepClone.java:33)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:981)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:896)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestTemplateMethod(QuarkusTestExtension.java:856)

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of `uname -a` or `ver`

No response

Output of `java -version`

17.0.2
18

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.7.5.Final

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

No response

Additional information

No response

The text was updated successfully, but these errors were encountered:

quarkus-bot · 2022-03-23T19:19:05Z

/cc @geoand

gsmet · 2022-03-23T19:23:23Z

Could you prepare a small reproducer? We run our tests with JDK 17 and 18 so there might be something specific to your project.

geoand · 2022-03-23T19:30:48Z

Something tells me there is some extra testing extension coming into play...

Like @gsmet says, we'll need a reproducer

snazy · 2022-03-24T07:35:02Z

Will put a reproducer together (or facepalm and close this issue, if one of our extensions is causing this w/ Java 17/18)

snazy · 2022-03-25T14:53:34Z

The extension's org.junit.jupiter.params.ParameterizedTestExtension from org.junit.jupiter:junit-jupiter-params

See quarkusio#24492

snazy · 2022-03-25T18:40:04Z

Reproducer pushed as a PR.
Parameterized tests getting a List created by Arrays.asList() fails, "plain" ArrayList works.

snazy · 2022-03-25T18:40:33Z

Haven't checked Guava's collections though.

famod · 2022-03-25T23:12:51Z

This reminds me a lot of x-stream/xstream#253 where I also documented a (not so pretty) alternate workaround.

So this is an upstream issue we cannot really do anything about, so I'm closing this.
Once (if ever) x-stream 1.5 sees the light of day, we'll look into integrating it.

Adding --add-opens=java.base/java.util=ALL-UNNAMED does not help.

I think you've got a typo there as the following makes the test pass (via surefire argLine):

--add-opens java.base/java.util=ALL-UNNAMED

(more specifically mvn test -f integration-tests/test-extension -Dtest=ParamsTest -Dsurefire.argLine.additional='--add-opens java.base/java.util=ALL-UNNAMED', but surefire.argLine.additional only exists in Quarkus CI/local buidl)

famod · 2022-03-25T23:13:23Z

PS: Anyway, thanks for reporting!

gsmet · 2022-03-25T23:49:02Z

Does it work with List.of()? Because if so, it’s probably what people will use with Java 17+.

famod · 2022-03-25T23:59:02Z

No, unfortunately: x-stream/xstream#253 (comment)

snazy · 2022-03-26T07:09:46Z

This reminds me a lot of x-stream/xstream#253

That's a kinda depressing issue to read :(

I think you've got a typo there (add-opens)

Well, not a typo (as I've added it to .mvn/jvm.config + .mvn/mvnd.properites). It's been a mistake to add it to the Maven JVM - should have added it to the JVM running the tests via surefire (my bad).

I'll probably just add the two --add-opens to Quarkus surefire/failsafe configs.

See quarkusio/quarkus#24492

See quarkusio#24492

…arameterizedTest` See quarkusio#24492

Relates to: quarkusio#24492

…arameterizedTest` See quarkusio#24492

Relates to: quarkusio#24492

See quarkusio#24492

Avoid XStream causing illegal access issues for internal JDK collections

Relates to: quarkusio#24492 (cherry picked from commit 2aee696)

See quarkusio#24492 (cherry picked from commit 7852ea9)

xtaixe · 2022-04-20T08:15:04Z

Hi.

I'm still seeing this on 2.8.1.Final when the @MethodSourcereturns a Stream<Map.Entry<String, String>>. The error is:

com.thoughtworks.xstream.converters.ConversionException: 
No converter available
---- Debugging information ----
message             : No converter available
type                : java.util.KeyValueHolder
converter           : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
message[1]          : Unable to make field final java.lang.Object java.util.KeyValueHolder.key accessible: module java.base does not "opens java.util" to unnamed module @7219ec67
-------------------------------

Let me know if you want me to create a new issue. cc @geoand

geoand · 2022-04-20T08:19:54Z

Please do

snazy added the kind/bug Something isn't working label Mar 23, 2022

quarkus-bot bot added the triage/needs-triage label Mar 23, 2022

famod added area/testing and removed triage/needs-triage labels Mar 23, 2022

gsmet added the triage/needs-reproducer We are waiting for a reproducer. label Mar 23, 2022

snazy added a commit to snazy/quarkus that referenced this issue Mar 25, 2022

Reproducer for Issue quarkusio#24492

37a6486

See quarkusio#24492

snazy changed the title ~~Quarkus testing broken with Java 17 + 18 (xstream)~~ Quarkus testing with @ParameterizedTest broken with Java 17 + 18 (xstream) Mar 25, 2022

snazy mentioned this issue Mar 25, 2022

Reproducer for Issue #24492 #24562

Closed

famod closed this as completed Mar 25, 2022

famod removed the triage/needs-reproducer We are waiting for a reproducer. label Mar 25, 2022

snazy added a commit to snazy/nessie that referenced this issue Mar 27, 2022

Let Quarkus Server tests run on Java 17+

4a21a10

See quarkusio/quarkus#24492

snazy mentioned this issue Mar 27, 2022

Let Quarkus Server tests run on Java 17+ projectnessie/nessie#3733

Merged

snazy added a commit to projectnessie/nessie that referenced this issue Mar 27, 2022

Let Quarkus Server tests run on Java 17+ (#3733)

3e057e6

See quarkusio/quarkus#24492

snazy added a commit to snazy/quarkus that referenced this issue Apr 7, 2022

Reproducer for Issue quarkusio#24492

ee66251

See quarkusio#24492

snazy added a commit to snazy/quarkus that referenced this issue Apr 7, 2022

Add tests + doc notes around "new-ish" collection types used with `@P…

1fa9808

…arameterizedTest` See quarkusio#24492

snazy mentioned this issue Apr 11, 2022

Add tests + doc notes around "new-ish" collection types used with @ParameterizedTest #24869

Closed

snazy added a commit to snazy/quarkus that referenced this issue Apr 11, 2022

Add tests + doc notes around "new-ish" collection types used with `@P…

cba33fa

…arameterizedTest` See quarkusio#24492

geoand added a commit to geoand/quarkus that referenced this issue Apr 11, 2022

Avoid XStream causing illegal access issues for internal JDK collections

f5a8bdd

Relates to: quarkusio#24492

geoand mentioned this issue Apr 11, 2022

Avoid XStream causing illegal access issues for internal JDK collections #24872

Merged

snazy added a commit to snazy/quarkus that referenced this issue Apr 11, 2022

Add tests + doc notes around "new-ish" collection types used with `@P…

897241c

…arameterizedTest` See quarkusio#24492

geoand added a commit to geoand/quarkus that referenced this issue Apr 11, 2022

Avoid XStream causing illegal access issues for internal JDK collections

8a78359

Relates to: quarkusio#24492

geoand added a commit to geoand/quarkus that referenced this issue Apr 11, 2022

Avoid XStream causing illegal access issues for internal JDK collections

544c21a

Relates to: quarkusio#24492

geoand added a commit to geoand/quarkus that referenced this issue Apr 11, 2022

Avoid XStream causing illegal access issues for internal JDK collections

2aee696

Relates to: quarkusio#24492

geoand pushed a commit to geoand/quarkus that referenced this issue Apr 11, 2022

Add tests around "new-ish" collection types used with @ParameterizedTest

48905a8

See quarkusio#24492

geoand pushed a commit to geoand/quarkus that referenced this issue Apr 11, 2022

Add tests around "new-ish" collection types used with @ParameterizedTest

7852ea9

See quarkusio#24492

geoand added a commit that referenced this issue Apr 11, 2022

Merge pull request #24872 from geoand/#24492

aa1f7ef

Avoid XStream causing illegal access issues for internal JDK collections

quarkus-bot bot added this to the 2.9 - main milestone Apr 11, 2022

gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 11, 2022

Avoid XStream causing illegal access issues for internal JDK collections

9572208

Relates to: quarkusio#24492 (cherry picked from commit 2aee696)

gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 11, 2022

Add tests around "new-ish" collection types used with @ParameterizedTest

393de9c

See quarkusio#24492 (cherry picked from commit 7852ea9)

gsmet modified the milestones: 2.9 - main, 2.8.1.Final Apr 11, 2022

xtaixe mentioned this issue Apr 20, 2022

Quarkus testing with @ParameterizedTest using Map (entries) broken with Java 17 + 18 (xstream) #25027

Closed

xtaixe mentioned this issue May 6, 2022

Quarkus testing with @ParameterizedTest using Optional broken with Java 17 + 18 (xstream) #25413

Closed

jakubbrzeski mentioned this issue Oct 19, 2022

Quarkus test with @ParameterizedTest and @MethodSource using List.subList does not work #28677

Closed

greyhairredbear mentioned this issue Apr 9, 2024

@QuarkusTest throws ConversionException in parameterized test on second parameter set with KClass parameter #38587

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quarkus testing with `@ParameterizedTest` broken with Java 17 + 18 (xstream) #24492

Quarkus testing with `@ParameterizedTest` broken with Java 17 + 18 (xstream) #24492

snazy commented Mar 23, 2022 •

edited

Loading

quarkus-bot bot commented Mar 23, 2022

gsmet commented Mar 23, 2022

geoand commented Mar 23, 2022

snazy commented Mar 24, 2022

snazy commented Mar 25, 2022

snazy commented Mar 25, 2022

snazy commented Mar 25, 2022

famod commented Mar 25, 2022

famod commented Mar 25, 2022

gsmet commented Mar 25, 2022 •

edited

Loading

famod commented Mar 25, 2022

snazy commented Mar 26, 2022

xtaixe commented Apr 20, 2022

geoand commented Apr 20, 2022

Quarkus testing with @ParameterizedTest broken with Java 17 + 18 (xstream) #24492

Quarkus testing with @ParameterizedTest broken with Java 17 + 18 (xstream) #24492

Comments

snazy commented Mar 23, 2022 • edited Loading

Describe the bug

Expected behavior

Actual behavior

How to Reproduce?

Output of uname -a or ver

Output of java -version

GraalVM version (if different from Java)

Quarkus version or git rev

Build tool (ie. output of mvnw --version or gradlew --version)

Additional information

quarkus-bot bot commented Mar 23, 2022

gsmet commented Mar 23, 2022

geoand commented Mar 23, 2022

snazy commented Mar 24, 2022

snazy commented Mar 25, 2022

snazy commented Mar 25, 2022

snazy commented Mar 25, 2022

famod commented Mar 25, 2022

famod commented Mar 25, 2022

gsmet commented Mar 25, 2022 • edited Loading

famod commented Mar 25, 2022

snazy commented Mar 26, 2022

xtaixe commented Apr 20, 2022

geoand commented Apr 20, 2022

Quarkus testing with `@ParameterizedTest` broken with Java 17 + 18 (xstream) #24492

Quarkus testing with `@ParameterizedTest` broken with Java 17 + 18 (xstream) #24492

snazy commented Mar 23, 2022 •

edited

Loading

Output of `uname -a` or `ver`

Output of `java -version`

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

gsmet commented Mar 25, 2022 •

edited

Loading