-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger UI don't show in dev mode from 2.7.0.Final #23991
Comments
Hi @yuhaibohotmail - so you are using '鈥橾' in the output somewhere? Do you have a reproducer ? |
nothing. here is a reproducer |
ok thanks. I'll have a look. |
Hi @yuhaibohotmail - i could not recreate this. Your reproducer works fine. Can you share some more details ? |
Hi @phillip-kruger , This bug only appears on Windows in dev mode, it works fine on MacOS 1.mp42.mp4 |
Ok, I'll see if I can recreate on Windows. |
@phillip-kruger I can't find the issue but someone also complained they had I wonder if it's a charset related issue. @yuhaibohotmail what is your locale/charset on Windows? |
My locale is zh-CN. |
Ok, I think this is bigger than openapi and graphql, we might need some help from someone in the vertx-http or similar extension. I have not yet managed to recreate this issue, but I left the locale/charset as default on Windows. I'll try again. @stuartwdouglas @cescoffier - do you have any idea if anything changed ? |
@yuhaibohotmail I am struggling to recreate the issue: |
I don't see that character in the file (in smallrye-open-api-ui-2.1.17.jar). I don't really see how this could be a charset issue, this should be served just using the vert.x static file handler, no charset processing should be done. |
In my editor it looks like:
|
@gsmet - There is no difference between the headers in 2.7.0 and 2.7.2 that I can see. |
Any idea what your default encoding is? |
And you mentioned it works on Edge ? But not on Chrome and Firefox ? |
E.g. what happens if you run: |
The browser is interpretting it as either If you do: |
swagger-ui-bundle.zip |
What headers do you see in the network tab of chrome? |
System.out.println(new String("\u2019".getBytes(StandardCharsets.UTF_8))); System.out.println(new String("\u2019]".getBytes(StandardCharsets.UTF_8), "GB18030")); |
yes , it works on Edge in dev mode. |
Linked PR should fix the issue. |
@stuartwdouglas Thanks a lot ! |
@stuartwdouglas |
Fixes quarkusio#23991 (cherry picked from commit ad36396)
Describe the bug
Chrome console error log:
Expected behavior
Show swagger ui
Actual behavior
Swagger UI don't Show in dev mode .
it works for versions prior to 2.7.0.CR1 in dev mode.
How to Reproduce?
openapibug.zip
Output of
uname -a
orver
Microsoft Windows [ 10.0.19043.1165]
Output of
java -version
Java(TM) SE Runtime Environment 18.9 (build 11.0.7+8-LTS)
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.7.2.final
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
Additional information
No response
The text was updated successfully, but these errors were encountered: