Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to run continuous testing on apple m1 #23075

Closed
jasonleung-hyphen opened this issue Jan 20, 2022 · 4 comments · Fixed by #23158
Closed

Failed to run continuous testing on apple m1 #23075

jasonleung-hyphen opened this issue Jan 20, 2022 · 4 comments · Fixed by #23158
Labels
area/continuous-testing area/kotlin kind/bug Something isn't working
Milestone
2.7.0.Final

Comments

@jasonleung-hyphen
Copy link

Describe the bug

After entered to continuous testing mode, it throws error Cannot mix both @QuarkusTest based tests and io.quarkus.test.junit.QuarkusTest based tests in the same run
but in fact @QuarkusTest is included in the test

example:

import io.quarkus.test.junit.QuarkusTest
import io.restassured.module.kotlin.extensions.Then
import io.restassured.module.kotlin.extensions.When
import org.hamcrest.CoreMatchers.`is`
import org.junit.jupiter.api.Test

@QuarkusTest
class KotlinResourceTest {

    @Test
    fun testHelloEndpoint() {
        When {
            get("/kotlin")
        } Then {
            statusCode(200)
            body(`is`("hello from kotlin"))
        }
    }
}

Expected behavior

No response

Actual behavior

2022-01-21 04:55:27,302 ERROR [io.qua.test] (Test runner thread) Test KotlinResourceTest failed 
: java.lang.IllegalStateException: Cannot mix both @QuarkusTest based tests and io.quarkus.test.junit.QuarkusTest based tests in the same run
        at io.quarkus.test.junit.QuarkusTestExtension.ensureStarted(QuarkusTestExtension.java:528)
        at io.quarkus.test.junit.QuarkusTestExtension.beforeAll(QuarkusTestExtension.java:589)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$10(ClassBasedTestDescriptor.java:381)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeBeforeAllCallbacks(ClassBasedTestDescriptor.java:381)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:205)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:80)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:148)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
        at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
        at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
        at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
        at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
        at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
        at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
        at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
        at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:95)
        at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:91)
        at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:60)
        at io.quarkus.deployment.dev.testing.JunitTestRunner.runTests(JunitTestRunner.java:222)
        at io.quarkus.deployment.dev.testing.TestRunner.runInternal(TestRunner.java:251)
        at io.quarkus.deployment.dev.testing.TestRunner$1.run(TestRunner.java:130)
        at java.base/java.lang.Thread.run(Thread.java:829)
        Suppressed: java.lang.NullPointerException
                at io.quarkus.test.junit.QuarkusTestExtension.runAfterAllCallbacks(QuarkusTestExtension.java:985)
                at io.quarkus.test.junit.QuarkusTestExtension.afterAll(QuarkusTestExtension.java:967)
                at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeAfterAllCallbacks$16(ClassBasedTestDescriptor.java:447)
                at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
                at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeAfterAllCallbacks$17(ClassBasedTestDescriptor.java:447)
                at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
                at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeAfterAllCallbacks(ClassBasedTestDescriptor.java:447)
                at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.after(ClassBasedTestDescriptor.java:229)
                at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.after(ClassBasedTestDescriptor.java:80)
                at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:161)
                at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
                at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:161)
                ... 31 more

How to Reproduce?

  1. ./gradlew quarkusDev
  2. enter continuous testing mode

Output of uname -a or ver

Darwin 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:41 PST 2021; root:xnu-8019.61.5~1/RELEASE_ARM64_T6000 arm64

Output of java -version

OpenJDK 64-Bit Server VM Zulu11.54+23-CA (build 11.0.14+9-LTS, mixed mode)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.3.1.Final

Build tool (ie. output of mvnw --version or gradlew --version)

7.3.3

Additional information

No response
@jasonleung-hyphen jasonleung-hyphen added the kind/bug Something isn't working label Jan 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

/cc @evanchooly, @stuartwdouglas

@stuartwdouglas
Copy link
Member

Can you provide a reproducer? That test works fine for me.

@jasonleung-hyphen
Copy link
Author

it seems related to @Nest test cases 🤔

@jasonleung-hyphen
Copy link
Author

Can you provide a reproducer? That test works fine for me.

@QuarkusTest
class ExampleTest {
    @Nested
    inner class Test1 {
        @Test
        fun `test1`() {
            Assertions.assertTrue(true)
        }
    }

    @Nested
    inner class Test2 {
        @BeforeEach
        fun setupMock() {

        }

        @Test
        fun `test2`() {
            Assertions.assertTrue(true)
        }
    }
}

stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Jan 25, 2022
@stuartwdouglas
Handle @nested with continuous testing
a464e10 
Fixes quarkusio#23075
@stuartwdouglas stuartwdouglas mentioned this issue Jan 25, 2022
Merged
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 25, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 25, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 25, 2022
@stuartwdouglas @gsmet
Handle @nested with continuous testing
ea55d14 
Fixes quarkusio#23075

(cherry picked from commit a464e10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/continuous-testing area/kotlin kind/bug Something isn't working
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging a pull request may close this issue.

Handle @Nested with continuous testing stuartwdouglas/quarkus
3 participants
@stuartwdouglas @gsmet @jasonleung-hyphen