Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@FormParam usage is broken for reactive REST client #23034

Closed
alesj opened this issue Jan 19, 2022 · 1 comment · Fixed by #23041
Closed

@FormParam usage is broken for reactive REST client #23034

alesj opened this issue Jan 19, 2022 · 1 comment · Fixed by #23041
Assignees
@geoand
Labels
area/rest-client kind/bug Something isn't working
Milestone
2.7.0.Final

Comments

@alesj
Copy link
Contributor

alesj commented Jan 19, 2022

Describe the bug

When using non-string parameters with reactive REST client, you get a class-cast exception.

Expected behavior

Non-string parameters should be converted to string using ParamConverter or eventually toString.

Actual behavior

All parameters are casted to String, hence class cast exception.

How to Reproduce?

Run SimpleTest from this repo/branch

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.6.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

This works for non-reactive REST client.
@alesj alesj added the kind/bug Something isn't working label Jan 19, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 19, 2022

/cc @michalszynkiewicz

@geoand geoand self-assigned this Jan 20, 2022
geoand added a commit to geoand/quarkus that referenced this issue Jan 20, 2022
@geoand
Take ParamConverterProvider into account for form params in REST Clie…
fd2f594 
…nt Reactive

Fixes: quarkusio#23034
@geoand geoand mentioned this issue Jan 20, 2022
Merged
geoand added a commit to geoand/quarkus that referenced this issue Jan 20, 2022
@geoand
Take ParamConverterProvider into account for form params in REST Clie…
1715389 
…nt Reactive

Fixes: quarkusio#23034
gsmet added a commit that referenced this issue Jan 24, 2022
@gsmet
Merge pull request #23041 from geoand/#23034
6c8c259 
Take ParamConverterProvider into account for form params in REST Client Reactive
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 24, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 24, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 24, 2022
@geoand @gsmet
Take ParamConverterProvider into account for form params in REST Clie…
b4ade63 
…nt Reactive

Fixes: quarkusio#23034
(cherry picked from commit 1715389)
@fwippe fwippe mentioned this issue Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/rest-client kind/bug Something isn't working
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging a pull request may close this issue.

Take ParamConverterProvider into account for form params in REST Client Reactive geoand/quarkus
3 participants
@alesj @gsmet @geoand