Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yasson library to support java 17 records #22184

Closed
lostiniceland opened this issue Dec 14, 2021 · 5 comments · Fixed by #22926
Closed

Update Yasson library to support java 17 records #22184

lostiniceland opened this issue Dec 14, 2021 · 5 comments · Fixed by #22926
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone

Comments

@lostiniceland
Copy link
Contributor

lostiniceland commented Dec 14, 2021

Description

Please update the Yasson depedency to at least 2.0.3 for proper record support. Currently (2.5.2) only 1.0.9 is shipped.

Overriding the dependency to force 2.0.3 breaks the quarkus compilation:

Caused by: java.lang.ClassNotFoundException: jakarta.json.bind.spi.JsonbProvider
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:455)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:405)

Implementation ideas

No response

@lostiniceland lostiniceland added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Dec 14, 2021
@gsmet
Copy link
Member

gsmet commented Dec 14, 2021

It's not possible to upgrade to 2.0.3 for the moment as that would mean moving to the jakarta.* packages globally. This is on our plan but we are not there yet.

@lostiniceland
Copy link
Contributor Author

I assume this means waiting for Quarkus 3 due to the breaking API.

@lostiniceland
Copy link
Contributor Author

@gsmet The Yasson team backported and improved the record support to the 1.x line and the release 1.0.11 is available on Maven Central.
eclipse-ee4j/yasson#499 (comment)

I will try to override the version in our project, but I am not sure if this will work with the quarkus-extension.

@gsmet
Copy link
Member

gsmet commented Jan 16, 2022

@lostiniceland ah cool. I'm surprised Dependabot didn't upgrade it for us. It should have.

Would you mind creating a PR with the upgrade to the BOM and we will see what CI has to say?

@lostiniceland
Copy link
Contributor Author

I am having some issue with running all tests locally (even before changing the BOM), which are probably caused by my local setup (had the same issue with Yasson due to localisation).
[ERROR] ConfigPropertiesTest.configProperties:99 expected: <empty> but was: <localhost.localdomain>
Hence I pushed the PR without verifying locally and relying on the workflow.
@gsmet somebody needs to approve the workflow to start the ci.

lostiniceland added a commit to lostiniceland/quarkus that referenced this issue Jan 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 16, 2022
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.3.Final Jan 18, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants