-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide method for QuarkusTestResourceLifecycleManager
s to get current config values or know what profile is running
#22074
Comments
/cc @geoand |
I think I've just run into a similar problem with |
I see where this is coming from, but I don't really see a way to implement it properly. |
If we could just get some context form what is running, say the current profile, that would work for me... I'm not read into the flow of this but I might assume that in the context of where |
This allows implementations to take different actions based on the profile they are being used with. Closes: quarkusio#22074
#22180 should provide the bare minimum for this, i.e. the |
This allows implementations to take different actions based on the profile they are being used with. Closes: quarkusio#22074
This allows implementations to take different actions based on the profile they are being used with. Closes: quarkusio#22074
Introduce context awareness into QuarkusTestResourceLifecycleManager
Description
Lifecyfle managers can need to spin up different services in different ways for different test profiles.
Currently, the only way for the
QuarkusTestResourceLifecycleManager
to know how setup resources from one test to another are throughinitArgs
. This works, but has a couple flaws:If
QuarkusTestResourceLifecycleManager
had a way to access at bare minimum what profile is currently running, or even had access to preliminary configs, it would eliminate the need for all the extra annotations.Implementation ideas
Just throwing ideas out, but concerning the
start()
method;Instead of returning values to override config, what if the
start()
method takes as a parameter the current configMap:start(Map<String, String> configMap)
. This would allow for both overrides to that map and for the manager to glean information about what profile might be running and what needs started up.Or just add a method or member to
QuarkusTestResourceLifecycleManager
that takes the current config/ running test profile that makes it available to implementations.The text was updated successfully, but these errors were encountered: