Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarkus-container-image-jib should support jib.dockerClient.executable config #21677

Closed
andrewazores opened this issue Nov 24, 2021 · 3 comments · Fixed by #21690
Closed

quarkus-container-image-jib should support jib.dockerClient.executable config #21677

andrewazores opened this issue Nov 24, 2021 · 3 comments · Fixed by #21690
Assignees
@geoand
Labels
area/container-image
Milestone
2.6.0.CR1

Comments

@andrewazores
Copy link

Jib allows configuration of the dockerClient that is invoked for loading the built image to local registry. This allows developers to explicitly build to docker, podman, buildah, etc. depending on what is available on their system as well as explicitly selecting one of them if multiple are present. This is analogous to the quarkus.docker.executable-name config property that is already supported, so I think it would make sense that the jib builder supports it as well.

There is also the dockerClient.executable config property that Jib supports which I think might be relevant here. If it is not then I think that a separate issue could be opened to add support for this to the quarkus-container-image-jib build plugin as quarkus.jib.dockerClient.executable=/usr/bin/podman. I use this in Cryostat to default the image builder to podman, but allow it to be overridden if some developer needs that to be docker (or probably buildah too - haven't tried that yet).

Originally posted by @andrewazores in #16326 (comment)
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 24, 2021

/cc @geoand

@geoand geoand self-assigned this Nov 24, 2021
@geoand
Copy link
Contributor

geoand commented Nov 24, 2021

Thanks. I'll add this tomorrow

@snowdrop-bot snowdrop-bot mentioned this issue Nov 24, 2021
Closed
geoand added a commit to geoand/quarkus that referenced this issue Nov 25, 2021
@geoand
Make docker executable configurable when using Jib
8053f50 
When Jib builds a container locally (as opposed to pushing to a registry),
it needs a docker executable to perform the build.
With this change, the name of that executable is now configurable
using either `quarkus.jib.docker-executable-name` or
`quarkus.docker.executable-name`

Resolves: quarkusio#21677
@geoand geoand mentioned this issue Nov 25, 2021
Merged
@geoand
Copy link
Contributor

geoand commented Nov 25, 2021

#21690 takes care of it

gastaldi added a commit that referenced this issue Nov 25, 2021
@gastaldi
Merge pull request #21690 from geoand/#21677
3f0ffd4 
Make docker executable configurable when using Jib
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 25, 2021
Postremus pushed a commit to Postremus/quarkus that referenced this issue Nov 25, 2021
@geoand @Postremus
Make docker executable configurable when using Jib
810a1af 
When Jib builds a container locally (as opposed to pushing to a registry),
it needs a docker executable to perform the build.
With this change, the name of that executable is now configurable
using either `quarkus.jib.docker-executable-name` or
`quarkus.docker.executable-name`

Resolves: quarkusio#21677
Postremus pushed a commit to Postremus/quarkus that referenced this issue Nov 27, 2021
@geoand @Postremus
Make docker executable configurable when using Jib
12903d8 
When Jib builds a container locally (as opposed to pushing to a registry),
it needs a docker executable to perform the build.
With this change, the name of that executable is now configurable
using either `quarkus.jib.docker-executable-name` or
`quarkus.docker.executable-name`

Resolves: quarkusio#21677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/container-image
Projects
None yet
Milestone
2.6.0.CR1
Development

Successfully merging a pull request may close this issue.

Make docker executable configurable when using Jib geoand/quarkus
2 participants
@andrewazores @geoand