-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC service applications should be able to accept GitHub tokens #20911
Comments
/cc @pedroigor |
CC @gastaldi |
@sberyozkin wouldn't this one be fixed by your ongoing PR? Or maybe already fixed? |
@gsmet Apologies, going through the list and finding I've missed a few comments. Unfortunately not; GitHub is not an OpenId Connect provider, so with the Quarkus OIDC So that works for For the bearer tokens, those coming with |
Description
Quarkus
OIDC
web-app
applications can already acquire a GitHub access token and indirectly verify it by requesting a user profile info from GitHub - but if thisweb-app
endpoint propagates this token to the downstream OIDCservice
endpoint then it will fail sinceGitHub
has no introspection endpoint.The same would be the case if SPA acquires a GitHub token and sends it to Quarkus.
Implementation ideas
OIDC
service
applications should indirectly verify GitHub token the same way this token is indirectly verified byweb-app
applications - by requesting some user info profile data via a configured GitHubuserinfo
endpoint.In fact, I've realized now - it will solve similar issues with many other non Keycloak providers like for ex Auth0 or Google where the access token is binary but no introspection endpoint is provided - for ex - Auth0 binary access tokens sent by OIDC DevUI will always return 401 (as opposed to JWT ID tokens which can be verified by JWKs).
The text was updated successfully, but these errors were encountered: