Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Tika users skip adding all charsets in native image #20839

Closed
sberyozkin opened this issue Oct 18, 2021 · 0 comments · Fixed by #21141
Closed

Let Tika users skip adding all charsets in native image #20839

sberyozkin opened this issue Oct 18, 2021 · 0 comments · Fixed by #21141
Assignees
@galderz
Labels
area/tika kind/enhancement New feature or request
Milestone
2.5.0.CR1

Comments

@sberyozkin
Copy link
Member

Description

#20837 adds all charsets in native image for quarkus-tika users to avoid adding them via configuration every time.
Adding all the charsets affects the native image size, so if it were possible to disable it with the build time configuration then it can help in cases where users work with PDFs known to contain for ex only English language characters.

Implementation ideas

No response
@sberyozkin sberyozkin added the kind/enhancement New feature or request label Oct 18, 2021
@galderz galderz mentioned this issue Oct 19, 2021
Merged
galderz added a commit to galderz/quarkus that referenced this issue Nov 2, 2021
@galderz
Revert "Enable all charsets in native image for quarkus-tika" quarkus…
093c9e1 
…io#20839

* This reverts commit 5d43d77.
* Reverted to bring back optional aspect of adding all charsets.
galderz added a commit to galderz/quarkus that referenced this issue Nov 2, 2021
@galderz
Limit pdfbox packages to initialize at runtime quarkusio#20839
dc85385 
* This avoids forcing charsets to be initialized at runtime.
@galderz galderz mentioned this issue Nov 2, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galderz galderz

Labels
area/tika kind/enhancement New feature or request
Projects
None yet
Milestone
2.5.0.CR1
Development

Successfully merging a pull request may close this issue.

Tweak runtime pdfbox packages to avoid needing all charsets in Tika galderz/quarkus
2 participants
@galderz @sberyozkin