-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micrometer custom MeterFilter not registered when not declared with @Produces annotation #20703
Comments
/cc @ebullient, @kenfinnigan |
Based on the description you have added I would say that can't happen. However since we have seen a lot of weird things, could you attach a sample project that exhibits the problematic behavior? |
Yes I am currently creating one smaller than our multi-module project. Thanks |
If you run in dev mode, was your |
Here is a small reproducer with two filters supposed to filter tags, one is working, the other seems not. So it seems I am able to reproduce even with the small project which is good. |
Great, thanks! |
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703
Fix Micrometer unremovable bean handling
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703 (cherry picked from commit 98ea1b5)
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703 (cherry picked from commit 98ea1b5)
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703 (cherry picked from commit 98ea1b5)
Arc is intelligent enough to only make a class unremovable if there is an actual bean of that type. It therefore suffices to let Arc know which types to make unremovable and not try to emulate the bean declaration logic Fixes: quarkusio#20703 (cherry picked from commit 98ea1b5)
Describe the bug
Hello,
While tryin to add a custom MeterFilter, I was able to do it following the guide, usin a CDI bean that produces MeterFiler beans.
However, annotating my class with Singleton to make it a bean did not work.
I was expecting that no matter the way the bean is declared, it would work, maybe I miss something ?
Expected behavior
Any MeterFilter bean would be added to the injectable MeterRegistry produced by quarkus extension
Actual behavior
Only bean created with @produces annotation are added to the list of MeterFilter
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: