Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with empty quarkus.container-image.group failing #20376

Closed
joggeli34 opened this issue Sep 24, 2021 · 1 comment · Fixed by #20404
Closed

Build with empty quarkus.container-image.group failing #20376

joggeli34 opened this issue Sep 24, 2021 · 1 comment · Fixed by #20404
Labels
area/container-image kind/bug Something isn't working
Milestone
2.3.0.Final

Comments

@joggeli34
Copy link
Contributor

Describe the bug

When starting quarkusBuild on a project configured with:

quarkus.container-image.group=

the build fails with:

The supplied combination of container-image group '' and name 'application-name' is invalid

This could probably be due to #19958

Expected behavior

It should build and then create a docker image without a group.

Actual behavior

No response

How to Reproduce?

Add

quarkus.container-image.group=

and run

gradlew quarkusBuild

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.3.0.CR1

Build tool (ie. output of mvnw --version or gradlew --version)

gradlew 7.2

Additional information

No response
@joggeli34 joggeli34 added the kind/bug Something isn't working label Sep 24, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 24, 2021

/cc @geoand

geoand added a commit to geoand/quarkus that referenced this issue Sep 27, 2021
@geoand
Reinstate ability to set an empty container-image group
d648de1 
Fixes: quarkusio#20376
@geoand geoand mentioned this issue Sep 27, 2021
Merged
geoand added a commit to geoand/quarkus that referenced this issue Sep 27, 2021
@geoand
Reinstate ability to set an empty container-image group
10ec5e4 
Fixes: quarkusio#20376
geoand added a commit that referenced this issue Sep 27, 2021
@geoand
Merge pull request #20404 from geoand/#20376
4c39153 
Reinstate ability to set an empty container-image group
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Sep 27, 2021
@geoand geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 28, 2021
geoand added a commit to geoand/quarkus that referenced this issue Sep 28, 2021
@geoand
Reinstate ability to set an empty container-image group
a8ab35f 
Fixes: quarkusio#20376
(cherry picked from commit 10ec5e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/container-image kind/bug Something isn't working
Projects
None yet
Milestone
2.3.0.Final
Development

Successfully merging a pull request may close this issue.

Reinstate ability to set an empty container-image group geoand/quarkus
3 participants
@geoand @famod @joggeli34