Resteasy Reactive: `ServerExceptionMapper` does not process a thrown `Exception` (Kotlin only) #20357

mschorsch · 2021-09-23T12:18:14Z

Describe the bug

If a (Kotlin-)Rest-Endpoint throws an java.lang.Exception then the Exception does not get processed by a custom ServerExceptionMapper. RuntimeException works as excepted.

org.acme.MyException
	at org.acme.ExceptionTestResource.throwException1Method(ExceptionTestResource.kt:33)
	at org.acme.ExceptionTestResource_Subclass.throwException1Method$$superforward1(ExceptionTestResource_Subclass.zig:113)
	at org.acme.ExceptionTestResource_Subclass$$function$$1.apply(ExceptionTestResource_Subclass$$function$$1.zig:24)
	at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:54)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor.proceed(InvocationInterceptor.java:62)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor.monitor(InvocationInterceptor.java:49)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor_Bean.intercept(InvocationInterceptor_Bean.zig:521)
	at io.quarkus.arc.impl.InterceptorInvocation.invoke(InterceptorInvocation.java:41)
	at io.quarkus.arc.impl.AroundInvokeInvocationContext.perform(AroundInvokeInvocationContext.java:41)
	at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:32)
	at org.acme.ExceptionTestResource_Subclass.throwException1Method(ExceptionTestResource_Subclass.zig:183)
	at org.acme.ExceptionTestResource_ClientProxy.throwException1Method(ExceptionTestResource_ClientProxy.zig:185)
	at org.acme.ExceptionTestResource$quarkusrestinvoker$throwException1Method_4a04d16e4f5785de322606c51c7fc425b79facd0.invoke(ExceptionTestResource$quarkusrestinvoker$throwException1Method_4a04d16e4f5785de322606c51c7fc425b79facd0.zig:33)
	at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)
	at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:7)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:141)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$13.runWith(VertxCoreRecorder.java:543)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
	at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
	at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:829)
Resulted in: io.quarkus.arc.ArcUndeclaredThrowableException: Error invoking subclass method
	at org.acme.ExceptionTestResource_Subclass.throwException1Method(ExceptionTestResource_Subclass.zig:205)
	... 12 more

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

https://code.quarkus.io/?e=resteasy-reactive-jackson&e=kotlin&extension-search=kotlin
Add the following code

package org.acme

import org.jboss.resteasy.reactive.server.ServerExceptionMapper
import javax.enterprise.context.ApplicationScoped
import javax.ws.rs.GET
import javax.ws.rs.Path
import javax.ws.rs.core.Response

open class SuperException : Exception() // Works if SuperException extends RuntimeException instead of Exception
class MyException : SuperException()

class ExceptionMappers {

    @ServerExceptionMapper
    fun superExceptionHandler(ex: SuperException): Response {
        println("SuperException processed")
        return Response.serverError().build()
    }
}

@ApplicationScoped
@Path("/ex")
class ExceptionTestResource {

    /**
     * Exception is not processed by the ServerExceptionMapper.
     */
    @GET
    @Path("/throw1")
    fun throwException1Method(): String {
        throw MyException()
    }

    /**
     * Exception is processed by the ServerExceptionMapper.
     */
    @GET
    @Path("/throw2")
    @Throws(MyException::class) // see here
    fun throwExceptionMethod(): String {
        throw MyException()
    }
}

Output of `uname -a` or `ver`

No response

Output of `java -version`

Java 11

GraalVM version (if different from Java)

No response

Quarkus version or git rev

Quarkus 2.2.3.Final

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

Maven 3.8.1

Additional information

No response

The text was updated successfully, but these errors were encountered:

quarkus-bot · 2021-09-23T12:18:16Z

/cc @FroMage, @evanchooly, @geoand, @stuartwdouglas

geoand · 2021-09-23T12:52:18Z

I can't reproduce this problem with the snippets included in the description.

Please attach a project that exhibits this behavior (ideally with failing tests).

mschorsch · 2021-09-23T14:03:12Z

I've made a reproducer (see attached), including some tests.

Please note that unfortunately the tests do not fail. The problem can only be reproduced in dev mode.

Run ./mvnw quarkus:dev call http://localhost:8080/ex/throw1 then you get the following exception (console log):

2021-09-23 16:01:39,381 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (executor-thread-0) HTTP Request to /ex/throw1 failed, error id: 4c3eb23b-e454-43fb-9c2c-96d44e308b1f-1: io.quarkus.arc.ArcUndeclaredThrowableException: Error invoking subclass method
	at org.acme.ExceptionTestResource_Subclass.throwException1Method(ExceptionTestResource_Subclass.zig:205)
	at org.acme.ExceptionTestResource_ClientProxy.throwException1Method(ExceptionTestResource_ClientProxy.zig:185)
	at org.acme.ExceptionTestResource$quarkusrestinvoker$throwException1Method_4a04d16e4f5785de322606c51c7fc425b79facd0.invoke(ExceptionTestResource$quarkusrestinvoker$throwException1Method_4a04d16e4f5785de322606c51c7fc425b79facd0.zig:33)
	at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)
	at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:7)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:141)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$13.runWith(VertxCoreRecorder.java:543)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
	at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
	at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: org.acme.MyException
	at org.acme.ExceptionTestResource.throwException1Method(ExceptionTestResource.kt:30)
	at org.acme.ExceptionTestResource_Subclass.throwException1Method$$superforward1(ExceptionTestResource_Subclass.zig:113)
	at org.acme.ExceptionTestResource_Subclass$$function$$1.apply(ExceptionTestResource_Subclass$$function$$1.zig:24)
	at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:54)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor.proceed(InvocationInterceptor.java:62)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor.monitor(InvocationInterceptor.java:49)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor_Bean.intercept(InvocationInterceptor_Bean.zig:521)
	at io.quarkus.arc.impl.InterceptorInvocation.invoke(InterceptorInvocation.java:41)
	at io.quarkus.arc.impl.AroundInvokeInvocationContext.perform(AroundInvokeInvocationContext.java:41)
	at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:32)
	at org.acme.ExceptionTestResource_Subclass.throwException1Method(ExceptionTestResource_Subclass.zig:183)
	... 12 more

2021-09-23 16:01:39,390 ERROR [org.jbo.res.rea.com.cor.AbstractResteasyReactiveContext] (executor-thread-0) Request failed: io.quarkus.arc.ArcUndeclaredThrowableException: Error invoking subclass method
	at org.acme.ExceptionTestResource_Subclass.throwException1Method(ExceptionTestResource_Subclass.zig:205)
	at org.acme.ExceptionTestResource_ClientProxy.throwException1Method(ExceptionTestResource_ClientProxy.zig:185)
	at org.acme.ExceptionTestResource$quarkusrestinvoker$throwException1Method_4a04d16e4f5785de322606c51c7fc425b79facd0.invoke(ExceptionTestResource$quarkusrestinvoker$throwException1Method_4a04d16e4f5785de322606c51c7fc425b79facd0.zig:33)
	at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)
	at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:7)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:141)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$13.runWith(VertxCoreRecorder.java:543)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
	at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
	at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: org.acme.MyException
	at org.acme.ExceptionTestResource.throwException1Method(ExceptionTestResource.kt:30)
	at org.acme.ExceptionTestResource_Subclass.throwException1Method$$superforward1(ExceptionTestResource_Subclass.zig:113)
	at org.acme.ExceptionTestResource_Subclass$$function$$1.apply(ExceptionTestResource_Subclass$$function$$1.zig:24)
	at io.quarkus.arc.impl.AroundInvokeInvocationContext.proceed(AroundInvokeInvocationContext.java:54)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor.proceed(InvocationInterceptor.java:62)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor.monitor(InvocationInterceptor.java:49)
	at io.quarkus.arc.runtime.devconsole.InvocationInterceptor_Bean.intercept(InvocationInterceptor_Bean.zig:521)
	at io.quarkus.arc.impl.InterceptorInvocation.invoke(InterceptorInvocation.java:41)
	at io.quarkus.arc.impl.AroundInvokeInvocationContext.perform(AroundInvokeInvocationContext.java:41)
	at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:32)
	at org.acme.ExceptionTestResource_Subclass.throwException1Method(ExceptionTestResource_Subclass.zig:183)
	... 12 more

reproducer20357.zip

Fixes: quarkusio#20357

geoand · 2021-09-23T16:18:46Z

#20364 takes care of the issue

Add the exception unwrapping capabilities to RESTEasy Reactive

Fixes: quarkusio#20357 (cherry picked from commit 538b3b7)

mschorsch added the kind/bug Something isn't working label Sep 23, 2021

quarkus-bot bot added area/kotlin area/rest labels Sep 23, 2021

geoand added the triage/needs-reproducer We are waiting for a reproducer. label Sep 23, 2021

geoand added a commit to geoand/quarkus that referenced this issue Sep 23, 2021

Add the exception unwrapping capabilities to RESTEasy Reactive

538b3b7

Fixes: quarkusio#20357

geoand mentioned this issue Sep 23, 2021

Add the exception unwrapping capabilities to RESTEasy Reactive #20364

Merged

geoand closed this as completed in #20364 Sep 24, 2021

geoand added a commit that referenced this issue Sep 24, 2021

Merge pull request #20364 from geoand/#20357

b938e53

Add the exception unwrapping capabilities to RESTEasy Reactive

quarkus-bot bot added this to the 2.4 - main milestone Sep 24, 2021

geoand modified the milestones: 2.4 - main, 2.3.0.Final Sep 28, 2021

geoand added a commit to geoand/quarkus that referenced this issue Sep 28, 2021

Add the exception unwrapping capabilities to RESTEasy Reactive

d494a1c

Fixes: quarkusio#20357 (cherry picked from commit 538b3b7)

famod removed the triage/needs-reproducer We are waiting for a reproducer. label Oct 4, 2021

mschorsch mentioned this issue Nov 23, 2021

Kotlin: ArcUndeclaredThrowableException since 1.13.x #21519

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resteasy Reactive: `ServerExceptionMapper` does not process a thrown `Exception` (Kotlin only) #20357

Resteasy Reactive: `ServerExceptionMapper` does not process a thrown `Exception` (Kotlin only) #20357

mschorsch commented Sep 23, 2021

quarkus-bot bot commented Sep 23, 2021

geoand commented Sep 23, 2021

mschorsch commented Sep 23, 2021

geoand commented Sep 23, 2021

Resteasy Reactive: ServerExceptionMapper does not process a thrown Exception (Kotlin only) #20357

Resteasy Reactive: ServerExceptionMapper does not process a thrown Exception (Kotlin only) #20357

Comments

mschorsch commented Sep 23, 2021

Describe the bug

Expected behavior

Actual behavior

How to Reproduce?

Output of uname -a or ver

Output of java -version

GraalVM version (if different from Java)

Quarkus version or git rev

Build tool (ie. output of mvnw --version or gradlew --version)

Additional information

quarkus-bot bot commented Sep 23, 2021

geoand commented Sep 23, 2021

mschorsch commented Sep 23, 2021

geoand commented Sep 23, 2021

Resteasy Reactive: `ServerExceptionMapper` does not process a thrown `Exception` (Kotlin only) #20357

Resteasy Reactive: `ServerExceptionMapper` does not process a thrown `Exception` (Kotlin only) #20357

Output of `uname -a` or `ver`

Output of `java -version`

Build tool (ie. output of `mvnw --version` or `gradlew --version`)