Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestAssured not configured to use the correct port when quarkus.http.test-ssl-port is set #20228

Closed
jamesnetherton opened this issue Sep 17, 2021 · 4 comments · Fixed by #30673
Labels
area/testing kind/bug Something isn't working
Milestone

Comments

@jamesnetherton
Copy link
Contributor

Describe the bug

When a custom value for quarkus.http.test-ssl-port is set, RestAssured seems to not be configured to use it. Digging into the code, it appears that it's actually attempting to be set by resolving config property quarkus.https.test-port.

https://github.com/quarkusio/quarkus/blob/main/test-framework/common/src/main/java/io/quarkus/test/common/RestAssuredURLManager.java#L118-L120

There's also a couple of other references to it in the codebase:

https://github.com/quarkusio/quarkus/search?q=%22quarkus.https.test-port%22

Expected behavior

The RestAssured port is configured to use the value of quarkus.http.test-ssl-port.

Actual behavior

RestAssured.port evaluates to 8444 and not the value of quarkus.http.test-ssl-port.

How to Reproduce?

Create a unit test where quarkus.http.test-ssl-port is configured. Then use RestAssured to try and hit a server endpoint.

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@jamesnetherton jamesnetherton added the kind/bug Something isn't working label Sep 17, 2021
@jamesnetherton jamesnetherton changed the title RestAssured not configured to use the correct port whenquarkus.http.test-ssl-port is set RestAssured not configured to use the correct port when quarkus.http.test-ssl-port is set Sep 17, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 17, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Jan 27, 2023

Is this still an issue? I vaguely remember us addressing something similar

@jamesnetherton
Copy link
Contributor Author

Issue still seems to be present in Quarkus 2.16.0.Final.

@geoand
Copy link
Contributor

geoand commented Jan 27, 2023

Interesting, thanks for the update

gastaldi added a commit to gastaldi/quarkus that referenced this issue Jan 27, 2023
Also change the port from which the secure connection is established from `quarkus.https.test-port` to `quarkus.http.test-ssl-port`

- Fixes quarkusio#20228
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants