Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support io.vertx.mutiny.ext.web.Router through @Observes CDI event #20185

Closed
murphye opened this issue Sep 15, 2021 · 3 comments · Fixed by #20192
Closed

Support io.vertx.mutiny.ext.web.Router through @Observes CDI event #20185

murphye opened this issue Sep 15, 2021 · 3 comments · Fixed by #20192
Milestone

Comments

@murphye
Copy link

murphye commented Sep 15, 2021

Description

I cannot implement void init(@Observes io.vertx.mutiny.ext.web.Router router) as only io.vertx.ext.web.Router seems to be supported. When I need the Mutiny Router, it forces me to do Router.newInstance(router) to convert the regular Router to a Mutiny Router.

When using libraries such as smallrye-mutiny-vertx-web-openapi this becomes an annoyance, as the Mutiny variant of the Router may be needed.

@cescoffier

Implementation ideas

No response

@murphye murphye added the kind/enhancement New feature or request label Sep 15, 2021
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/mutiny area/smallrye labels Sep 15, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 15, 2021

/cc @cescoffier, @jponge, @manovotn, @mkouba

@murphye
Copy link
Author

murphye commented Sep 15, 2021

Example located here
https://github.com/murphye/vertx-web-openapi-quarkus-petstore/blob/resource-defect/src/main/java/org/acme/Main.java#L61

Router.newInstance(router).mountSubRouter("/", apiRouter); // Convert to Mutiny Router and mount apiRouter at '/'

@cescoffier
Copy link
Member

Thanks @murphye, that is something we can add easily.

@mkouba mkouba self-assigned this Sep 16, 2021
@mkouba mkouba added area/vertx and removed area/arc Issue related to ARC (dependency injection) area/smallrye labels Sep 16, 2021
cescoffier added a commit to cescoffier/quarkus that referenced this issue Sep 16, 2021
@mkouba mkouba removed their assignment Sep 16, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants