Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in mongodb-client integration tests #20139

Closed
jsmrcka opened this issue Sep 14, 2021 · 4 comments · Fixed by #20146
Closed

Inconsistency in mongodb-client integration tests #20139

jsmrcka opened this issue Sep 14, 2021 · 4 comments · Fixed by #20146
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/mongodb
Milestone

Comments

@jsmrcka
Copy link
Contributor

jsmrcka commented Sep 14, 2021

Description

While checking for Mongo test coverage, we noticed an inconsistency introduced by #12902.

Originally, there were two tests in integration-tests/mongodb-client/src/test/java/io/quarkus/it/mongodb/BookResourceTest.java which were removed:

Their respective endpoints, however, were kept intact:

  • integration-tests/mongodb-client/src/main/java/io/quarkus/it/mongodb/discriminator/VehicleResource.java
  • integration-tests/mongodb-client/src/main/java/io/quarkus/it/mongodb/pojo/PojoResource.java

What was the reason for the removal?
Would it be possible to either add the tests back, or remove the related enpoints?

Implementation ideas

No response

@jsmrcka jsmrcka added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Sep 14, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2021

/cc @evanchooly, @loicmathieu

@loicmathieu
Copy link
Contributor

@jsmrcka nice catch! This should have been a merge issue, those two tests can be re-integrated.
Would you mind sending a PR ?

@jsmrcka
Copy link
Contributor Author

jsmrcka commented Sep 14, 2021

@loicmathieu Sure thing, I'll make it ready.

@loicmathieu
Copy link
Contributor

Thanks

jsmrcka added a commit to jsmrcka/quarkus that referenced this issue Sep 14, 2021
@loicmathieu loicmathieu added this to the 2.3 - main milestone Sep 14, 2021
jsmrcka added a commit to jsmrcka/quarkus that referenced this issue Sep 16, 2021
jsmrcka added a commit to jsmrcka/quarkus that referenced this issue Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/mongodb
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants