-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in mongodb-client integration tests #20139
Labels
Milestone
Comments
jsmrcka
added
the
area/housekeeping
Issue type for generalized tasks not related to bugs or enhancements
label
Sep 14, 2021
/cc @evanchooly, @loicmathieu |
@jsmrcka nice catch! This should have been a merge issue, those two tests can be re-integrated. |
@loicmathieu Sure thing, I'll make it ready. |
Thanks |
jsmrcka
added a commit
to jsmrcka/quarkus
that referenced
this issue
Sep 14, 2021
jsmrcka
added a commit
to jsmrcka/quarkus
that referenced
this issue
Sep 16, 2021
jsmrcka
added a commit
to jsmrcka/quarkus
that referenced
this issue
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
While checking for Mongo test coverage, we noticed an inconsistency introduced by #12902.
Originally, there were two tests in
integration-tests/mongodb-client/src/test/java/io/quarkus/it/mongodb/BookResourceTest.java
which were removed:testVehicleEndpoint
(https://github.com/quarkusio/quarkus/pull/12902/files#diff-adad68742f7dc851850e5b594177697da7a5313144b74da9ca4dccfe19e5aeeaL135)testPojoEndpoint
(https://github.com/quarkusio/quarkus/pull/12902/files#diff-adad68742f7dc851850e5b594177697da7a5313144b74da9ca4dccfe19e5aeeaL155)Their respective endpoints, however, were kept intact:
integration-tests/mongodb-client/src/main/java/io/quarkus/it/mongodb/discriminator/VehicleResource.java
integration-tests/mongodb-client/src/main/java/io/quarkus/it/mongodb/pojo/PojoResource.java
What was the reason for the removal?
Would it be possible to either add the tests back, or remove the related enpoints?
Implementation ideas
No response
The text was updated successfully, but these errors were encountered: