Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using RestResponse<T> as return type for rest client #19966

Closed
andreas-eberle opened this issue Sep 7, 2021 · 2 comments · Fixed by #19978
Closed

Allow using RestResponse<T> as return type for rest client #19966

andreas-eberle opened this issue Sep 7, 2021 · 2 comments · Fixed by #19978
Assignees
Labels
Milestone

Comments

@andreas-eberle
Copy link
Contributor

Description

The rest client (reactive) allows to use Response as a return type for rest methods. Unfortunately, Response is not typed at all and thus when you want to access the status code of the response, you cannot specify the type of the response in the rest client interface. This is not so nice, because ideally, you'd like to specify the whole api in that interface.

In contrast, the RestResponse<T> class can already be used in resteasy-reactive for returning a type response. Please also add support for RestResponse<T> return types in the rest client (reactive).

Implementation ideas

No response

@andreas-eberle andreas-eberle added the kind/enhancement New feature or request label Sep 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 7, 2021

/cc @michalszynkiewicz

@geoand
Copy link
Contributor

geoand commented Sep 7, 2021

This is a very good idea!

I'll take a look

@geoand geoand self-assigned this Sep 7, 2021
geoand added a commit to geoand/quarkus that referenced this issue Sep 7, 2021
geoand added a commit to geoand/quarkus that referenced this issue Sep 7, 2021
geoand added a commit to geoand/quarkus that referenced this issue Sep 8, 2021
geoand added a commit that referenced this issue Sep 9, 2021
Support RestResponse<T> as a return type for reactive rest client methods
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants