Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting labels for container-image-docker #19903

Closed
crissi98 opened this issue Sep 3, 2021 · 1 comment · Fixed by #19943
Closed

Add support for setting labels for container-image-docker #19903

crissi98 opened this issue Sep 3, 2021 · 1 comment · Fixed by #19943
Assignees
Labels
Milestone

Comments

@crissi98
Copy link

crissi98 commented Sep 3, 2021

Description

When building docker-images with the container-image-docker extension I would like to set metadata via labels for the built image. These labels should be set when performing docker build via the --label option. To specify the labels to be set, there should be a config-option, e.g. quarkus.docker.labelswith type Map<String, String>

Implementation ideas

The arguments for the docker build to set the labels could be set within this method:

private String[] getDockerArgs(String image, DockerfilePaths dockerfilePaths, DockerConfig dockerConfig) {

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 3, 2021

/cc @geoand

@geoand geoand self-assigned this Sep 6, 2021
geoand added a commit to geoand/quarkus that referenced this issue Sep 6, 2021
geoand added a commit to geoand/quarkus that referenced this issue Sep 6, 2021
geoand added a commit that referenced this issue Sep 7, 2021
Make labels a general container-image setting instead of Jib specific
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants