Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port rest-data-panache to RESTEasy Reactive #19771

Closed
geoand opened this issue Aug 30, 2021 · 4 comments · Fixed by #19801
Closed

Port rest-data-panache to RESTEasy Reactive #19771

geoand opened this issue Aug 30, 2021 · 4 comments · Fixed by #19801
Assignees
Milestone

Comments

@geoand
Copy link
Contributor

geoand commented Aug 30, 2021

Description

quarkus-rest-data-panache currently depends on RESTEasy Classic.
We should port this to RESTEasy Reactive.
This won't be trivial as RESTEasy Reactive builds all the necessary information by looking at the Jandex index of existing code, while rest-data-panache generates code which isn't available at this point.

Implementation ideas

No response

@geoand geoand added the kind/enhancement New feature or request label Aug 30, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2021

/cc @FroMage, @loicmathieu, @stuartwdouglas

@loicmathieu
Copy link
Contributor

I'm not convinced by this one.
Maybe we need to create a rest-data-panache-rx based on RestEasy reactive and provides both flavor.
Rest-data-panache is opinionated, and provides easy to use REST endpoints based on conventions for quick usage, advanced use case will not use it so accoring to me having it using the simpliest extensions is OK.

As I understand it, soon, resteasy classic will be based on resteasy reactive so this may not be very important.

@geoand
Copy link
Contributor Author

geoand commented Aug 30, 2021

I'm not convinced by this one.
Maybe we need to create a rest-data-panache-rx based on RestEasy reactive and provides both flavor.
Rest-data-panache is opinionated, and provides easy to use REST endpoints based on conventions for quick usage, advanced use case will not use it so accoring to me having it using the simpliest extensions is OK.

Agreed. But the base itself provides no additional features. The under the covers transition to RESTEasy Reactive should be absolutely transparent (apart from the different transitive dependencies).
rest-data-panache-rx wouldn't provide anything different. What am talking about here is simply swapping the underlying REST layer.
From a user perspective there should be no change at all.

As I understand it, soon, resteasy classic will be based on resteasy reactive so this may not be very important.

Not true. What will happen likely is that we will be proposing resteasy-reactive as the default API layer.

@geoand
Copy link
Contributor Author

geoand commented Aug 31, 2021

Closed by accident, so I am reopening

@geoand geoand reopened this Aug 31, 2021
geoand added a commit to geoand/quarkus that referenced this issue Aug 31, 2021
geoand added a commit that referenced this issue Sep 2, 2021
Port rest-data-panache to RESTEasy Reactive
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants