JUnit: Wrong test method passed in TestInfo parameter of BeforeEach/AfterEach methods

[jonathan-meier]

Describe the bug

Consider the following test class:

package com.esri.karl.api;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInfo;

import io.quarkus.test.junit.QuarkusTest;

@QuarkusTest
public final class TestInfoTest {

	@BeforeEach
	void before(TestInfo testInfo) {
		testInfo.getTestMethod().ifPresent(m -> System.out.println(m.getName())); // prints "before", should print "testMethod"
	}

	@AfterEach
	void after(TestInfo testInfo) {
		testInfo.getTestMethod().ifPresent(m -> System.out.println(m.getName())); // prints "after", should print "testMethod"
	}

	@Test
	void testMethod() {}

}

Expected behavior

The currently running test method annotated with @Test (testMethod in the test class above) should be passed via testInfo in before and after.

Actual behavior

The methods before and after are passed in respectively, which is wrong.

How to Reproduce?

Repro: Just run the test class provided above in Quarkus 2.2.0.Final.

Additional information

Quarkus version 2.1.4.Final works as expected. This is likely a regression introduced with PR #19518.

Likely also related: the class of the passed test method has a different class loader than the class of the currently executing before/after method.

package com.esri.karl.api;

import java.lang.annotation.Annotation;
import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInfo;
import org.junit.platform.commons.util.AnnotationUtils;

import io.quarkus.test.junit.QuarkusTest;

@QuarkusTest
public final class TestInfoTest {

	@Target(ElementType.METHOD)
	@Retention(RetentionPolicy.RUNTIME)
	public @interface TestAnnotation { }

	@BeforeEach
	void before(TestInfo testInfo) throws ClassNotFoundException {
		System.out.println(AnnotationUtils.isAnnotated(testInfo.getTestMethod(), TestAnnotation.class)); // prints "false", should print "true"
		System.out.println(AnnotationUtils.isAnnotated(testInfo.getTestMethod(),
				(Class<? extends Annotation>) testInfo.getTestMethod().get().getDeclaringClass().getClassLoader().loadClass(TestAnnotation.class.getName()))); // prints "true"
	}

	@AfterEach
	void after(TestInfo testInfo) throws ClassNotFoundException {
		System.out.println(AnnotationUtils.isAnnotated(testInfo.getTestMethod(), TestAnnotation.class)); // prints "false", should print "true"
		System.out.println(AnnotationUtils.isAnnotated(testInfo.getTestMethod(),
				(Class<? extends Annotation>) testInfo.getTestMethod().get().getDeclaringClass().getClassLoader().loadClass(TestAnnotation.class.getName()))); // prints "true"
	}

	@Test
	@TestAnnotation
	void testAnnotation() {}

}

[jonathan-meier]

/cc @stuartwdouglas

[quarkus-bot]

/cc @geoand

[famod]

I have a fix for this, will send a PR soon.

[famod]

#19751 should take care of it. Thanks for reporting, btw!

[jonathan-meier]

@famod Thanks a lot for providing a fix so quickly. Our JUnit tests are all green again with version 2.2.1.Final 👍

[famod]

@jonathan-meier great to hear! Just beware that there is a regression w.r.t. @Before/AfterAll: #19800
That will be fixed in 2.2.2.Final.