-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Quarkus 2.2.0 breaks Dev Mode on Windows #19673
Comments
/cc @stuartwdouglas |
I think this is the same issue as what we fixed recently here #19510. Temporary workaround till that fix makes it to a release, is to use Maven 3.8.1 instead of Maven 3.8.2 |
I did in fact first encounter the issue with Maven 3.6.2. I have now also tested with Maven 3.8.1, but the result is the same there. |
Looking at the error message I can however also not see the |
I have the same problem. |
@jaikiran The fix you mention is already in 2.2.0.Final so that must be something else. @knutwannheden Are you sure you use 2.2.0.Final for both the BOM and the Maven plugin? Because it shouldn't use the old jansi anymore in 2.2.0.Final AFAIK. |
@gsmet I am quite positive, but I will give it another try and report back here. |
@aloubyansky what is the command to get the full deployment dependency tree? Is it possible to get the one from dev mode? |
|
@knutwannheden could you get us the output of ^ |
|
I created a new application using code.quarkus.io only containing |
Yes, 2.2.0.Final is not released yet. Only the core artifacts are. |
Oh yes, so the problem is different, it's with jansi, not jline.
@knutwannheden do you confirm, using the exact same version of Maven, you have 2.1.3.Final working and 2.2.0.Final not working for the same project? |
Yes, with 2.1.3 and no other changes this works. |
Output for 2.1.3:
|
@knutwannheden could you try adding the dependency on jansi to the quarkus-maven-plugin, e.g.
|
I just ran this again now and the error is slightly different from what I originally reported: Here are the relevant parts from the stack trace:
|
I just tried that, but it doesn't help. |
I have no idea why the error is slightly different now... |
And what if you try
|
Do you launch it with |
With that |
That's what has changed. |
It also works with Maven 3.8.2 that way. |
I got this other error message when I tested with Maven 3.8.2. The initially reported error is what I got with Maven 3.6.2 and 3.8.1. AFAIK currently Maven 3.8.1 is still recommended. |
It's not the issue with the app classpath, it's the plugin classpath. |
@knutwannheden you should be able to reproduce it using the main branch, right? Would you be able to test a change? |
Yes, I can probably do that. |
Here is a quick & dirty attempt to switch to Aesh (already used in quarkus-core-deployment) from JLine for the Prompter. @knutwannheden would you mind giving another try to this branch? https://github.com/aloubyansky/quarkus/tree/exclude-jline-from-maven-plugin |
It report error with maven-3.8.2 , 3.8.1 or 3.6.3. |
@aloubyansky Same here: Same error with your new commit. |
I am moving the Prompter class back to the quarkus-maven-plugin and switching to Aesh. Aesh is already a dependency of quarkus-core-deployment. |
Could somebody please test this aloubyansky@4b37776 and if it fails post the complete stacktrace? Thanks. |
AFAICT the exception is still the same:
I haven't stepped through the code, but is it really related to the |
It doesn't look like it anymore. There is no jline anymore shading another version of jansi. |
It looks like my current branch at https://github.com/aloubyansky/quarkus/commits/exclude-jline-from-maven-plugin is working for @knutwannheden
@yuhaibohotmail will you be able to confirm whether the branch works for you as well, just in case? I'll look into cleaning it up then and prepare a PR. |
It work for me, thanks! |
Thanks @yuhaibohotmail! |
I'm having same problem on windows 10 this #19673 (comment) Thanks |
Describe the bug
When trying to start a Quarkus 2.2.0 application in dev-mode (using
mvn quarkus:dev
) I get the following error printed to the console and the application fails to start:With Quarkus 2.1.3 the same application works without issues.
Expected behavior
Dev Mode should also work on Windows.
Actual behavior
See description.
How to Reproduce?
No response
Output of
uname -a
orver
MSYS_NT-10.0-22000 WIN10-KNUT 3.1.7-340.x86_64 2020-10-23 13:08 UTC x86_64 Msys
Output of
java -version
openjdk version "11.0.9" 2020-10-20 LTS OpenJDK Runtime Environment Zulu11.43+22-SA (build 11.0.9+11-LTS) OpenJDK 64-Bit Server VM Zulu11.43+22-SA (build 11.0.9+11-LTS, mixed mode)
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.2.0.Final
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
Additional information
No response
The text was updated successfully, but these errors were encountered: