Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSources DevService doesnt follow the same logs patterns as other devServices #19573

Closed
pjgg opened this issue Aug 23, 2021 · 3 comments · Fixed by #19575
Closed

DataSources DevService doesnt follow the same logs patterns as other devServices #19573

pjgg opened this issue Aug 23, 2021 · 3 comments · Fixed by #19575
Assignees
@gsmet
Labels
area/devservices kind/enhancement New feature or request
Milestone
2.2.0.Final

Comments

@pjgg
Copy link
Contributor

pjgg commented Aug 23, 2021 •
edited
Loading

Describe the bug

I am missing the following Log in postgresql | mysql | mariadb | Mssql devService:

Dev Services for <DATABASE_KIND> started.

As other devServices do, for example:

Amqp (follow this pattern):

1.      Pulling docker image: quay.io/artemiscloud/activemq-artemis-broker
2.      Please be patient; this may take some time but only needs to be done once
3.      Starting to pull image
4.      Dev Services for AMQP started

RedPanda:

1. Pulling docker image: vectorized/redpanda
2. Please be patient; this may take some time but only needs to be done once
3. Starting to pull image
4.  Dev Services for Kafka started

But Postgres follow this pattern:

1. Pulling docker image: postgresql
2. Please be patient; this may take some time but only needs to be done once
3. Starting to pull image

I think that is important to have a unified log and also explicitly says that DevService <DATABASE_KIND> was started

Expected behavior

Dev Services for <DATABASE_KIND> started
@pjgg pjgg added the kind/bug Something isn't working label Aug 23, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2021

/cc @stuartwdouglas

@gsmet
Copy link
Member

gsmet commented Aug 23, 2021

I will have a look at this one and the other one #19485

@gsmet gsmet self-assigned this Aug 23, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Aug 23, 2021
@gsmet
Bring some consistency in Dev Services startup logs
2d915e6 
Fixes quarkusio#19573
Fixes quarkusio#19485
gsmet added a commit to gsmet/quarkus that referenced this issue Aug 23, 2021
@gsmet
Bring some consistency in Dev Services startup logs
feacf3c 
Fixes quarkusio#19573
Fixes quarkusio#19485
@gsmet gsmet mentioned this issue Aug 23, 2021
Merged
@gsmet
Copy link
Member

gsmet commented Aug 23, 2021

See #19575

gsmet added a commit to gsmet/quarkus that referenced this issue Aug 23, 2021
@gsmet
Bring some consistency in Dev Services startup logs
7ae7e9f 
Fixes quarkusio#19573
Fixes quarkusio#19485
@gsmet gsmet added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Aug 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 23, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.0.Final Aug 23, 2021
gsmet added a commit to gsmet/quarkus that referenced this issue Aug 23, 2021
@gsmet
Bring some consistency in Dev Services startup logs
bf070d2 
Fixes quarkusio#19573
Fixes quarkusio#19485

(cherry picked from commit 7ae7e9f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsmet gsmet

Labels
area/devservices kind/enhancement New feature or request
Projects
None yet
Milestone
2.2.0.Final
Development

Successfully merging a pull request may close this issue.

Bring some consistency in Dev Services startup logs gsmet/quarkus
2 participants
@gsmet @pjgg