Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESTEasy Reactive multipart - way to override default charset and content type #19527

Closed
jsmrcka opened this issue Aug 20, 2021 · 1 comment · Fixed by #19578
Closed

RESTEasy Reactive multipart - way to override default charset and content type #19527

jsmrcka opened this issue Aug 20, 2021 · 1 comment · Fixed by #19578
Assignees
@geoand
Labels
area/rest kind/enhancement New feature or request
Milestone
2.2.0.Final

Comments

@jsmrcka
Copy link
Contributor

jsmrcka commented Aug 20, 2021

Description

Multipart support in quarkus-resteasy-reactive is missing a way to override default charset for multipart body, similar to the quarkus.resteasy.multipart.input-part.default-charset property in quarkus-resteasy-multipart.
There is also no equivalent of another property, quarkus.resteasy.multipart.input-part.default-content-type.
See https://quarkus.io/guides/rest-json#multipart-support.

Implementation ideas

No response
@jsmrcka jsmrcka added the kind/enhancement New feature or request label Aug 20, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 20, 2021

/cc @FroMage, @geoand, @stuartwdouglas

jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this issue Aug 20, 2021
@jsmrcka
Add RESTEasy Reactive JAX-RS scenario
808a13a 
Add `http/jaxrs-reactive`, which is a RESTEasy reactive equivalent of
`http/jaxrs`.
Notable differenes and limitations:
- In a multipart POJO, Java type for `image` and `octet-stream` were
  changed from `InputStream` to `File` - `InputStream` is not supported
  by `resteasy-reactive`.
- Test of a functionality provided by the
  `quarkus.resteasy.multipart.input-part.default-charset` property has
  been disabled for now - it is unsupported in `resteasy-reactive`.
  quarkusio/quarkus#19527
- [FIXED] Possible bug in `resteasy-reactive` - endpoints  consuming
  `MULTIPART_FORM_DATA` cause build failure.
  quarkusio/quarkus#19404.
- Tests dealing with `text/plain` request/response have been disabled
  on Windows due to a bug.
  quarkusio/quarkus#19535
jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this issue Aug 20, 2021
@jsmrcka
Add RESTEasy Reactive JAX-RS scenario
c2eccd7 
Add `http/jaxrs-reactive`, which is a RESTEasy reactive equivalent of
`http/jaxrs`.
Notable differences and limitations:
- In a multipart POJO, Java type for `image` and `octet-stream` were
  changed from `InputStream` to `File` - `InputStream` is not supported
  by `resteasy-reactive`.
- Test of a functionality provided by the
  `quarkus.resteasy.multipart.input-part.default-charset` property has
  been disabled for now - it is unsupported in `resteasy-reactive`.
  quarkusio/quarkus#19527
- [FIXED] Possible bug in `resteasy-reactive` - endpoints  consuming
  `MULTIPART_FORM_DATA` cause build failure.
  quarkusio/quarkus#19404.
- Tests dealing with `text/plain` request/response have been disabled
  on Windows due to a bug.
  quarkusio/quarkus#19535
@jsmrcka jsmrcka mentioned this issue Aug 20, 2021
Merged
jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this issue Aug 20, 2021
@jsmrcka
Add RESTEasy Reactive JAX-RS scenario
9f03526 
Add `http/jaxrs-reactive`, which is a RESTEasy reactive equivalent of
`http/jaxrs`.
Notable differences and limitations:
- In a multipart POJO, Java type for `image` and `octet-stream` were
  changed from `InputStream` to `File` - `InputStream` is not supported
  by `resteasy-reactive`.
- Test of a functionality provided by the
  `quarkus.resteasy.multipart.input-part.default-charset` property has
  been disabled for now - it is unsupported in `resteasy-reactive`.
  quarkusio/quarkus#19527
- [FIXED] Possible bug in `resteasy-reactive` - endpoints  consuming
  `MULTIPART_FORM_DATA` cause build failure.
  quarkusio/quarkus#19404.
- Tests dealing with `text/plain` request/response have been disabled
  on Windows due to a bug.
  quarkusio/quarkus#19535
@geoand geoand self-assigned this Aug 23, 2021
geoand added a commit to geoand/quarkus that referenced this issue Aug 23, 2021
@geoand
Allow customization of default content type for Multipart handling
816752b 
Also changes the default to UTF-8 and apply some minor polish

Resolves: quarkusio#19527
@geoand geoand mentioned this issue Aug 23, 2021
Merged
@snowdrop-bot snowdrop-bot mentioned this issue Aug 23, 2021
Closed
geoand added a commit that referenced this issue Aug 24, 2021
@geoand
Merge pull request #19578 from geoand/#19527
d1e65ac 
Allow customization of default content type for Multipart handling
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 24, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.0.Final Aug 24, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 24, 2021
@geoand @gsmet
Allow customization of default content type for Multipart handling
0990dde 
Also changes the default to UTF-8 and apply some minor polish

Resolves: quarkusio#19527
(cherry picked from commit 816752b)
jsmrcka added a commit to jsmrcka/quarkus-test-suite that referenced this issue Aug 25, 2021
@jsmrcka
Add RESTEasy Reactive JAX-RS scenario
fea051b 
Add `http/jaxrs-reactive`, which is a RESTEasy reactive equivalent of
`http/jaxrs`.
Notable differences and limitations:
- In a multipart POJO, Java type for `image` and `octet-stream` were
  changed from `InputStream` to `File` - `InputStream` is not supported
  by `resteasy-reactive`.
- Test of a functionality provided by the
  `quarkus.resteasy.multipart.input-part.default-charset` property has
  been disabled for now - it is unsupported in `resteasy-reactive`.
  quarkusio/quarkus#19527
- [FIXED] Possible bug in `resteasy-reactive` - endpoints  consuming
  `MULTIPART_FORM_DATA` cause build failure.
  quarkusio/quarkus#19404.
- Tests dealing with `text/plain` request/response have been disabled
  on Windows due to a bug.
  quarkusio/quarkus#19535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Milestone
2.2.0.Final
Development

Successfully merging a pull request may close this issue.

Allow customization of default content type for Multipart handling geoand/quarkus
3 participants
@gsmet @geoand @jsmrcka