Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grpc DevUI output form resizing and missing test icons #19218

Closed
kshpak opened this issue Aug 4, 2021 · 3 comments · Fixed by #19536
Closed

Grpc DevUI output form resizing and missing test icons #19218

kshpak opened this issue Aug 4, 2021 · 3 comments · Fixed by #19536
Assignees
Labels
area/grpc gRPC kind/bug Something isn't working
Milestone

Comments

@kshpak
Copy link
Contributor

kshpak commented Aug 4, 2021

Describe the bug

[User Interface related]

  1. Output form height increasing at every method call
    Causes: https://github.com/quarkusio/quarkus/blob/main/extensions/grpc/deployment/src/main/resources/dev-templates/service.html#L102

  2. Tool(test) icon for redirecting to service methods is missing for Health endpoint and Steaming services (can be accessed only by directly accessing service URL e.x. http://localhost:8080/q/dev/io.quarkus.quarkus-grpc/service?name=helloworld.Streaming)

image

Expected behavior

  1. Output form height is properly adjusted by the output size
  2. Test redirect icons are present for Health and Streaming services

Actual behavior

No response

How to Reproduce?

Reproducer: https://github.com/kshpak/quarkus-reproducers/tree/main/grpc-devui

  1. mvn clean quarkus:dev
  2. Access http://localhost:8080/q/dev/io.quarkus.quarkus-grpc/services

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.1.0.Final

Build tool (ie. output of mvnw --version or gradlew --version)

mvn 3.8.1

Additional information

No response

@kshpak kshpak added the kind/bug Something isn't working label Aug 4, 2021
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Aug 4, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 4, 2021

/cc @cescoffier, @michalszynkiewicz

@michalszynkiewicz
Copy link
Member

There's one more thing that's wrong, the name of the streaming bean is the name of the generated class instead of the user's class. I will try to fix it too.

@michalszynkiewicz
Copy link
Member

all the things but the service name are fixed, I'll leave the issue open to handle the service name as a part of it, if you don't mind

michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Aug 20, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 23, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants