quarkus-redis-client needs ZUNION method

[kafeltz]

The ZUNION method is missing in the quarkus-redis-client. Currently there is only the ZUNIONSTORE method.

This one: https://redis.io/commands/zunion

[quarkus-bot]

/cc @cescoffier, @gsmet, @machi1990

[patrox]

@kafeltz @machi1990 I can address this missing functionality if you aren't already working on this one.

[patrox]

It seems like Vert.x Redis client (which is used by quarkus-redis-client) will have to be updated as well, as it doesn't support ZUNION: https://github.com/vert-x3/vertx-redis-client/blob/master/src/main/java/io/vertx/redis/client/RedisAPI.java#L3500-L3516

[machi1990]

It seems like Vert.x Redis client (which is used by quarkus-redis-client) will have to be updated as well, as it doesn't support ZUNION: https://github.com/vert-x3/vertx-redis-client/blob/master/src/main/java/io/vertx/redis/client/RedisAPI.java#L3500-L3516

@patrox thanks for the interest in fixing the issue. Yes, the command might need to be added in upstream first in Vertx 4. @pmlopes WDYT?

As an alternative for now:

You can try using the plain vertx io.vertx.redis.client.Redis client. And use it to send the command.

redis.send(Request.cmd(Command.ZUNION).arg("arg1").arg("arg2").arg("arg3"), res -> {
  if (res.succeeded()) {
    
  }
});

using the mutiny based client: io.quarkus.redis.client.runtime.MutinyRedis will be the most appropriate

mutinyRedis.send(Request.cmd(Command.ZUNION).arg("arg1").arg("arg2").arg("arg3"))....

[patrox]

Thank you @machi1990 for the alternative suggestion, I can try that as I won't have to wait for the upstream change.

I created a feature request in Vert.x Redis Client to address this in a longer term as well:

vert-x3/vertx-redis-client#299

[machi1990]

Thank you @machi1990 for the alternative suggestion, I can try that as I won't have to wait for the upstream change.

Thanks, let me know how it goes.

I created a feature request in Vert.x Redis Client to address this in a longer term as well:

vert-x3/vertx-redis-client#299

Awesome. Thank you.

[patrox]

redis.send(Request.cmd(Command.ZUNION).arg("arg1").arg("arg2").arg("arg3"), res -> {
  if (res.succeeded()) {
    
  }
});

@machi1990 I'm afraid we won't be able to proceed this way, as the Command enum doesn't include the ZUNION value :(

I updated it already on my PR which I'm going to open in vert.x redis client: https://github.com/patrox/vertx-redis-client/pull/1/files.

Maybe there should be a possibility to pass there plain Strings (i.e. "ZUNION") instead of Command values (Command.ZUNION) ?

[machi1990]

redis.send(Request.cmd(Command.ZUNION).arg("arg1").arg("arg2").arg("arg3"), res -> {
  if (res.succeeded()) {
    
  }
});

@machi1990 I'm afraid we won't be able to proceed this way, as the Command enum doesn't include the ZUNION value :(

@patrox thanks for finding sometime to look at this.

Yes, we'll have to create a new command Command.create("zunion".....).

I updated it already on my PR which I'm going to open in vert.x redis client: https://github.com/patrox/vertx-redis-client/pull/1/files.

It seems that this has been fixed in vert-x3/vertx-redis-client@8d78307, we can wait for the new release and add all the new commands. It seems like there are couple others commands which might be useful. What do you think?
And as for now, we can document how the user can handcraft missing commands (see #18378 )

Maybe there should be a possibility to pass there plain Strings (i.e. "ZUNION") instead of Command values (Command.ZUNION) ?

Yes, we'll have to create a new command Command.create("zunion".....).

[patrox]

In the meantime @pmlopes has added the commands from a recent Redis server version (including ZUNION) to vert.x Redis client, so probably we will be able to use the new version soon .

[patrox]

@machi1990 Yes, I saw the other new commands which were added, so I can add these as well.

I'll monitor vert.x redis client to see if there is a new version.

I can also document the workaround method as well - is it OK to do it in a single PR ? I can create separate commits for these changes.

[machi1990]

@machi1990 Yes, I saw the other new commands which were added, so I can add these as well.

I'll monitor vert.x redis client to see if there is a new version.

I can also document the workaround method as well - is it OK to do it in a single PR ? I can create separate commits for these changes.

I think what we can do is document the workaround for now in a separate PR and we'll fix the issue once a new release of the redis client is there.

[pmlopes]

@machi1990 @patrox the fix will arrive with vert.x 4.2.0.

The workaround required defining the zunion command, you can do it as:

public static final Command ZUNION = Command.create("zunion", -3, 0, 0, 0, false, true, true, false);

See the latest generation for 6.2.4 sources:

https://github.com/vert-x3/vertx-redis-client/blob/master/src/main/java/io/vertx/redis/client/Command.java

[patrox]

@machi1990 @patrox the fix will arrive with vert.x 4.2.0.

The workaround required defining the zunion command, you can do it as:

public static final Command ZUNION = Command.create("zunion", -3, 0, 0, 0, false, true, true, false);

See the latest generation for 6.2.4 sources:

https://github.com/vert-x3/vertx-redis-client/blob/master/src/main/java/io/vertx/redis/client/Command.java

Thanks @pmlopes, this is exactly what I was looking for!

[kafeltz]

@patrox I think the reactive library needs the zunion function too. Have you seen it?

[gastaldi]

Quarkus is using Vert.x 4.2.2. Is this still an issue?

[gsmet]

I think we probably still need to bind the new commands in the Quarkus impl if not already done.