-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentelemetry server templating does not work with template in class Path annotation #18251
Comments
/cc @kenfinnigan |
From a brief look it's valid for |
Yes, it is valid - albeit not widely used :) |
kenfinnigan
added a commit
to kenfinnigan/quarkus
that referenced
this issue
Sep 3, 2021
- Fixes quarkusio#18251 - Add test to Micrometer integration test. Verified not a problem with RESTEasy Reactive - Add test to OpenTelemetry integration test to very fix for RESTEasy Classic
kenfinnigan
added a commit
to kenfinnigan/quarkus
that referenced
this issue
Sep 3, 2021
- Fixes quarkusio#18251 - Add test to Micrometer integration test. Verified not a problem with RESTEasy Reactive - Add test to OpenTelemetry integration test to very fix for RESTEasy Classic
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Sep 6, 2021
- Fixes quarkusio#18251 - Add test to Micrometer integration test. Verified not a problem with RESTEasy Reactive - Add test to OpenTelemetry integration test to very fix for RESTEasy Classic (cherry picked from commit d57ddba)
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Sep 6, 2021
- Fixes quarkusio#18251 - Add test to Micrometer integration test. Verified not a problem with RESTEasy Reactive - Add test to OpenTelemetry integration test to very fix for RESTEasy Classic (cherry picked from commit d57ddba)
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this issue
Sep 6, 2021
- Fixes quarkusio#18251 - Add test to Micrometer integration test. Verified not a problem with RESTEasy Reactive - Add test to OpenTelemetry integration test to very fix for RESTEasy Classic (cherry picked from commit d57ddba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I'm not sure whether this should even be allowed, but when adding a Path annotation with a template parameter to a class the server span contains the actual path of the request instead of the templated version.
According to @kenfinnigan it is worth figuring out what is supposed to happen here.
Expected behavior
Either Quarkus should complain about the template parameter in that place or the template should be correctly replaced.
Actual behavior
The actual url without replacement is used as the name of the server span.
To Reproduce
The problem is reproducible with a resource similar to:
The resulting name of the span has the full path of e.g.
/tracing/filter/1234
instead of the template/tracing/filter/{dummy}
.in contrast templating is working fine with
Quarkus version or git rev
2.0.0.Final
The text was updated successfully, but these errors were encountered: