Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive SQL Client Documentation Missing Information #18056

Closed
ethan-gallant opened this issue Jun 22, 2021 · 2 comments · Fixed by #18076
Closed

Reactive SQL Client Documentation Missing Information #18056

ethan-gallant opened this issue Jun 22, 2021 · 2 comments · Fixed by #18076
Assignees
@tsegismont
Labels
area/reactive-sql-clients kind/bug Something isn't working
Milestone
2.0.0.Final

Comments

@ethan-gallant
Copy link
Contributor

Describe the bug

In the docs here https://quarkus.io/version/main/guides/reactive-sql-clients it says to create prepared statements with $1 $2 $3 etc. However, this appears to be Postgres specific as the Vert.x MySQL reactive library expects arguments to be passed as Question marks ?.

Expected behaviour

The docs should have a bubble stating that ? should be used for MySQL and $1,$2,$3 etc is only applicable for Postgres SQL.

Additional context

Not sure if I am missing anything here or if it's already been documented. I am not sure what the best way to iterate this information in the docs, but I would be glad to open a PR.
@ethan-gallant ethan-gallant added the kind/bug Something isn't working label Jun 22, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 22, 2021

/cc @tsegismont, @vietj

@tsegismont tsegismont self-assigned this Jun 22, 2021
@tsegismont
Copy link
Contributor

Thanks for pointing this out @ethan-gallant . I will update the doc

tsegismont added a commit to tsegismont/quarkus that referenced this issue Jun 22, 2021
@tsegismont
Reactive SQL guide: document placeholders
f14807b 
Fixes quarkusio#18056

Reactive SQL clients use different placeholders for prepared queries.
Now the database clients details section shows the differences.
tsegismont added a commit to tsegismont/quarkus that referenced this issue Jun 22, 2021
@tsegismont
Reactive SQL guide: document placeholders
d3548d5 
Fixes quarkusio#18056

Reactive SQL clients use different placeholders for prepared queries.
Now the database clients details section shows the differences.
@tsegismont tsegismont mentioned this issue Jun 22, 2021
Merged
gsmet pushed a commit to tsegismont/quarkus that referenced this issue Jun 22, 2021
@tsegismont @gsmet
Reactive SQL guide: document placeholders
d7ef14b 
Fixes quarkusio#18056

Reactive SQL clients use different placeholders for prepared queries.
Now the database clients details section shows the differences.
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 22, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 22, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jun 22, 2021
@tsegismont @gsmet
Reactive SQL guide: document placeholders
0d2a54f 
Fixes quarkusio#18056

Reactive SQL clients use different placeholders for prepared queries.
Now the database clients details section shows the differences.

(cherry picked from commit d7ef14b)
patrox pushed a commit to patrox/quarkus that referenced this issue Jun 23, 2021
@tsegismont @patrox
Reactive SQL guide: document placeholders
18d86f6 
Fixes quarkusio#18056

Reactive SQL clients use different placeholders for prepared queries.
Now the database clients details section shows the differences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
area/reactive-sql-clients kind/bug Something isn't working
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging a pull request may close this issue.

Reactive SQL guide: document placeholders tsegismont/quarkus
3 participants
@gsmet @tsegismont @ethan-gallant