Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive RestClient fails to start if 'quarkus.tls.trust-all' is set #16656

Closed
sberyozkin opened this issue Apr 20, 2021 · 3 comments · Fixed by #16685
Closed

Reactive RestClient fails to start if 'quarkus.tls.trust-all' is set #16656

sberyozkin opened this issue Apr 20, 2021 · 3 comments · Fixed by #16685
Assignees
@michalszynkiewicz
Labels
area/rest area/rest-client kind/bug Something isn't working
Milestone
2.0.0.Alpha1

Comments

@sberyozkin
Copy link
Member

Describe the bug

Setting quarkus,tls.trust-all=true leads to

Caused by: java.lang.ClassNotFoundException: io.quarkus.restclient.NoopHostnameVerifier
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:421)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:371)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:421)
	at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:371)
	at io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilder.registerHostnameVerifier(RestClientCDIDelegateBuilder.java:150)

Expected behavior

It is documented that HostnameVerifier is not supported right now - not sure if it is a permanent restriction though. Perhaps for now it should fail with a more informative warning
@sberyozkin sberyozkin added kind/bug Something isn't working area/rest labels Apr 20, 2021
@geoand
Copy link
Contributor

geoand commented Apr 20, 2021

cc @michalszynkiewicz

@michalszynkiewicz
Copy link
Member

@sberyozkin do you get this error on main or some release version?

We need to support this flag so I will implement this instead of adding a better error message.

@michalszynkiewicz michalszynkiewicz self-assigned this Apr 20, 2021
@sberyozkin
Copy link
Member Author

sberyozkin commented Apr 21, 2021 •
edited
Loading

@michalszynkiewicz

@sberyozkin do you get this error on main or some release version?

main

We need to support this flag so I will implement this instead of adding a better error message.

+1

michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Apr 21, 2021
@michalszynkiewicz
Rest Client Reactive - support for quarkus.tls.trust-all
1296a1a 
fixes quarkusio#16656
@michalszynkiewicz michalszynkiewicz mentioned this issue Apr 21, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 21, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 2.0.0.Alpha1 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalszynkiewicz michalszynkiewicz

Labels
area/rest area/rest-client kind/bug Something isn't working
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging a pull request may close this issue.

Rest Client Reactive - support for quarkus.tls.trust-all michalszynkiewicz/quarkus
4 participants
@sberyozkin @gsmet @michalszynkiewicz @geoand