Qute type-safe expression in type-safe message results in NPE #16590

manuelbl · 2021-04-16T16:18:39Z

Describe the bug

If a collection-like parameter for a Qute template is declared using the {@type name} syntax and collection items are then used as a parameter for type-safe messages, Quarkus is unable to build and start.

Expected behavior

Type-safe message parameters work whether the argument type has been declared in the template or not.

Actual behavior

Quarkus is unable to build (or start in dev mode) as a NullPointerException occurs during the build phase.

The bug does not occur for simple types, but for collection types.

Stack trace:

2021-04-16 17:53:59,592 ERROR [io.qua.dep.dev.IsolatedDevModeMain] (vert.x-worker-thread-1) Failed to start quarkus: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
java.lang.NullPointerException
	at io.quarkus.qute.deployment.Types.isAssignableFrom(Types.java:116)
	at io.quarkus.qute.deployment.MessageBundleProcessor.validateMessageBundleMethodsInTemplates(MessageBundleProcessor.java:410)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:920)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2415)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1452)
	at java.base/java.lang.Thread.run(Thread.java:832)
	at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Resulted in: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.qute.deployment.MessageBundleProcessor#validateMessageBundleMethodsInTemplates threw an exception: java.lang.NullPointerException
	at io.quarkus.qute.deployment.Types.isAssignableFrom(Types.java:116)
	at io.quarkus.qute.deployment.MessageBundleProcessor.validateMessageBundleMethodsInTemplates(MessageBundleProcessor.java:410)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:920)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2415)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1452)
	at java.base/java.lang.Thread.run(Thread.java:832)
	at org.jboss.threads.JBossThread.run(JBossThread.java:501)

	at io.quarkus.builder.Execution.run(Execution.java:116)
	at io.quarkus.builder.BuildExecutionBuilder.execute(BuildExecutionBuilder.java:79)
	at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:153)
	at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:394)
	at io.quarkus.runner.bootstrap.AugmentActionImpl.reloadExistingApplication(AugmentActionImpl.java:282)
	at io.quarkus.runner.bootstrap.AugmentActionImpl.reloadExistingApplication(AugmentActionImpl.java:66)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.restartApp(IsolatedDevModeMain.java:189)
	at io.quarkus.deployment.dev.IsolatedDevModeMain.restartCallback(IsolatedDevModeMain.java:175)
	at io.quarkus.deployment.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:254)
	at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$2.handle(VertxHttpHotReplacementSetup.java:62)
	at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$2.handle(VertxHttpHotReplacementSetup.java:52)
	at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:313)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:832)
Resulted in: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.qute.deployment.MessageBundleProcessor#validateMessageBundleMethodsInTemplates threw an exception: java.lang.NullPointerException
	at io.quarkus.qute.deployment.Types.isAssignableFrom(Types.java:116)
	at io.quarkus.qute.deployment.MessageBundleProcessor.validateMessageBundleMethodsInTemplates(MessageBundleProcessor.java:410)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:920)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2415)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1452)
	at java.base/java.lang.Thread.run(Thread.java:832)
	at org.jboss.threads.JBossThread.run(JBossThread.java:501)

	at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:396)
	... 12 more

To Reproduce

Minimal project to reproduce: message-in-loop.zip

The problematic line is the first line of page.txt (see snippet below). It results in an exception. If it is removed, it no longer crashes and the page can be opened from a browser at http://localhost:8080/hello-resteasy

{@java.util.List<java.lang.String> names}
{#each names}
    {msg:hello(it)}
{/each}

Steps to reproduce the behavior:

Start the attached project in dev mode: mvnw compile quarkus:dev

Environment (please complete the following information):

Output of `uname -a` or `ver`

Microsoft Windows [Version 10.0.19042.928]

Output of `java -version`

openjdk version "14.0.1" 2020-04-14
OpenJDK Runtime Environment (build 14.0.1+7)
OpenJDK 64-Bit Server VM (build 14.0.1+7, mixed mode, sharing)

Quarkus version or git rev

1.32.2.Final

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Users\xxx\.m2\wrapper\dists\apache-maven-3.6.3-bin\1iopthnavndlasol9gbrbg6bf2\apache-maven-3.6.3
Java version: 14.0.1, vendor: Oracle Corporation, runtime: C:\Users\xxx\.jdks\openjdk-14.0.1
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

The text was updated successfully, but these errors were encountered:

quarkus-bot · 2021-04-16T16:18:41Z

/cc @mkouba

- NPE is currently thrown if a type-safe message expression references a parent expression via hint - resolves quarkusio#16590

mkouba · 2021-04-19T08:33:05Z

Thanks for reporting! This bug should be fixed in #16618.

- NPE is currently thrown if a type-safe message expression references a parent expression via hint - resolves quarkusio#16590 (cherry picked from commit cb2305f)

manuelbl added the kind/bug Something isn't working label Apr 16, 2021

quarkus-bot bot added area/qute The template engine env/windows Impacts Windows machines labels Apr 16, 2021

mkouba self-assigned this Apr 19, 2021

mkouba added a commit to mkouba/quarkus that referenced this issue Apr 19, 2021

Qute - fix validation of type-safe message expressions

cb2305f

- NPE is currently thrown if a type-safe message expression references a parent expression via hint - resolves quarkusio#16590

mkouba mentioned this issue Apr 19, 2021

Qute - fix validation of type-safe message expressions #16618

Merged

FroMage closed this as completed in #16618 Apr 20, 2021

quarkus-bot bot added this to the 2.0 - main milestone Apr 20, 2021

gsmet modified the milestones: 2.0.0.Alpha1, 1.13.3.Final Apr 26, 2021

mkouba mentioned this issue Apr 28, 2021

Qute NullPointerException in build when combining MessageBundle with TemplateExtension method #16868

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qute type-safe expression in type-safe message results in NPE #16590

Qute type-safe expression in type-safe message results in NPE #16590

manuelbl commented Apr 16, 2021

quarkus-bot bot commented Apr 16, 2021

mkouba commented Apr 19, 2021

Qute type-safe expression in type-safe message results in NPE #16590

Qute type-safe expression in type-safe message results in NPE #16590

Comments

manuelbl commented Apr 16, 2021

Describe the bug

Expected behavior

Actual behavior

To Reproduce

Environment (please complete the following information):

Output of uname -a or ver

Output of java -version

Quarkus version or git rev

Build tool (ie. output of mvnw --version or gradlew --version)

quarkus-bot bot commented Apr 16, 2021

mkouba commented Apr 19, 2021

Output of `uname -a` or `ver`

Output of `java -version`

Build tool (ie. output of `mvnw --version` or `gradlew --version`)