Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus Kafka Client ServiceBinding no longer works with app-services service binding #16477

Closed
DuncanDoyle opened this issue Apr 13, 2021 · 1 comment · Fixed by #16481
Closed
Labels
Milestone

Comments

@DuncanDoyle
Copy link
Contributor

Describe the bug

Since a camelCase/lowerCase bug has been solved in the ServiceBinding operator/sdk, the binding files created by SBO respect the lowercase and uppercase defined in the metadata of the CRD.

Since the KafkaConnection CRD uses camelCase for bootstrapServer, saslMechanism and securityProtocol, and the Quarkus Kafka client uses all lowercase names, service binding for Kafka no longer works.

See: https://github.com/redhat-developer/app-services-operator/blob/main/olm/olm-catalog/rhoas-operator/0.6.7/manifests/rhoas-operator.kafkaconnections.crd.yaml#L6

This has been temporarily fixed in version 0.6.7 of our operator by also specifying full lowercase properties (and thus bindingfiles), but this is only done to support older Quarkus versions. Quarkus should align with the camelCase naming conventions.

Expected behavior

Kafka client service binding works with camelCase binding files.

Actual behavior

Kafka client expects lowercase binding files.

To Reproduce

Use Service Binding with app-services operator < 0.6.7

Environment (please complete the following information):

OpenShift 4.7, App Services Operator < 0.6.7, SBO >=0.6

Quarkus version or git rev

999-SNAPSHOT

Build tool (ie. output of mvnw --version or gradlew --version)

mvn 3.6.3

@DuncanDoyle DuncanDoyle added the kind/bug Something isn't working label Apr 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

/cc @cescoffier, @geoand

geoand pushed a commit to DuncanDoyle/quarkus that referenced this issue Apr 13, 2021
geoand pushed a commit to DuncanDoyle/quarkus that referenced this issue Apr 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 13, 2021
@gsmet gsmet modified the milestones: 2.0 - main, 1.13.2.Final Apr 14, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 14, 2021
DavideD pushed a commit to DavideD/quarkus that referenced this issue Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants