Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use application name (if set) as Kafka group.id #15632

Closed
cescoffier opened this issue Mar 11, 2021 · 2 comments · Fixed by #15678
Closed

Use application name (if set) as Kafka group.id #15632

cescoffier opened this issue Mar 11, 2021 · 2 comments · Fixed by #15678
Assignees
@Ladicek
Labels
area/kafka kind/enhancement New feature or request
Milestone
1.13.0.CR1

Comments

@cescoffier
Copy link
Member

Description

At the moment, the group.id is:

  • not set in prod mode - meaning that the user must set it
  • is generated to be a unique id in dev mode - to facilitate the hot reload

It would be great to set the group.id to the application name if that name is set.

Implementation ideas

If the application name is set, add the "kafka.group.id" property.
@cescoffier cescoffier added the kind/enhancement New feature or request label Mar 11, 2021
@cescoffier cescoffier changed the title Use application mae (if set) as Kafka group.id Use application name (if set) as Kafka group.id Mar 11, 2021
@cescoffier
Copy link
Member Author

@michalszynkiewicz / @Ladicek fancy a simple one?

@Ladicek
Copy link
Contributor

Ladicek commented Mar 11, 2021

Sure, that makes sense, and looks like I should be able to handle it with my limited skills :-)

@Ladicek Ladicek self-assigned this Mar 11, 2021
Ladicek added a commit to Ladicek/quarkus that referenced this issue Mar 12, 2021
@Ladicek
use application name as default Kafka consumer group.id
86ccf73 
Resolves quarkusio#15632
@Ladicek Ladicek mentioned this issue Mar 12, 2021
Merged
Ladicek added a commit to Ladicek/quarkus that referenced this issue Mar 12, 2021
@Ladicek
Use application name as default Kafka consumer group.id
beecdd1 
Resolves quarkusio#15632
Ladicek added a commit to Ladicek/quarkus that referenced this issue Mar 12, 2021
@Ladicek
Use application name as default Kafka consumer group.id
f6db501 
Resolves quarkusio#15632
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ladicek Ladicek

Labels
area/kafka kind/enhancement New feature or request
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging a pull request may close this issue.

Use application name as default Kafka consumer group.id Ladicek/quarkus
2 participants
@cescoffier @Ladicek