-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTEasy Reactive: Sub resource Path Params more than 2 levels back are not passed correctly #15114
Comments
/cc @FroMage, @geoand, @stuartwdouglas |
@stuartwdouglas mind taking a look at this one since you did most of the subresource stuff? |
I will have a look, however this particular bit was done by someone else :-) |
I must have erased it from my mind completely 🙈 |
Thanks @stuartwdouglas @geoand . I've confirmed it's working even with 4 levels of resources. |
Hahaha, I'm pretty sure we talked about this commit at the time and I noted it was only for a single level ;) 👻 🐛 |
🤣 |
But OK, I was wrong, I said we had to use a stack and @stuartwdouglas used a chained list ;) |
Somehow I had completely forgotten about it... It's all a blur! |
[image: image.png]
Looks like I'm a wildling :-)
…On Fri, Feb 19, 2021 at 11:18 AM Georgios Andrianakis < ***@***.***> wrote:
Somehow I had completely forgotten about it...
It's all a blur!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15114 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMB23ONOD75HUFT2TTGHGTS7YUH3ANCNFSM4XWVP75Q>
.
|
TBH I don't have a clue how I could have remembered that and not what I did yesterday. I guess it's like those SMB secret blocks I still remember from childhood, there's special brain storage for random stuff. |
I want a brain upgrade :P |
Fixes quarkusio#15114 (cherry picked from commit 7beab6d)
Describe the bug
Sub resource path params are not bound correctly in a scenario with more than two sub resource levels.
E.g. if path /trees/{treeId}/branches/{branchId}/leaves/{leafId} is handled by a sub resource "LeavesResource" which uses @PathParam("treeId") and @PathParam("branchId") and @PathParam("leafId") then treeId is not injected while the other two are.
Expected behavior
Multiple levels should be supported. The correct behaviour is found in standard resteasy.
Actual behavior
The value is not injected causing difficult to track bugs.
To Reproduce
git clone https://github.com/bcluap/quarkus-examples.git
cd quarkus-examples/resteasy-reactive
mvn clean test
Configuration
Nothing abnormal
Screenshots
Run the reproducer to see failures. Change the pom to non-reactive mode and all tests pass
Environment (please complete the following information):
This is not environment-specific
999-SNAPSHOT and before
Additional context
NA
The text was updated successfully, but these errors were encountered: