OIDC Client does not use connection-delay property

[bwand]

Describe the bug
When using the OID Client and starting the app without running Keycloak it crashes instantly and does not respect the connection-delay property as the normal OIDC stuff does.

Expected behavior
OIDC Client should wait and retry the connection for the configured connection-delay

Actual behavior
App tries to start and crashes instantly:

Attaching to ingest
ingest           | exec java -Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager -XX:+ExitOnOutOfMemoryError -cp . -jar /deployments/app.jar
ingest           | Feb 10, 2021 8:46:01 AM org.jboss.threads
ingest           | INFO: JBoss Threads version %s
ingest           | Feb 10, 2021 8:46:02 AM io.quarkus.oidc.client.runtime.OidcClientRecorder
ingest           | INFO: Connecting to IDP for up to %d times every 2 seconds
ingest           | Feb 10, 2021 8:46:03 AM io.quarkus.runtime.ApplicationLifecycleManager run
ingest           | ERROR: Failed to start application (with profile prod)
ingest           | java.net.ConnectException: Connection refused
ingest           | 	at java.base/sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
ingest           | 	at java.base/sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:779)
ingest           | 	at io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:330)
ingest           | 	at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:334)
ingest           | 	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:702)
ingest           | 	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:650)
ingest           | 	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:576)
ingest           | 	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)
ingest           | 	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
ingest           | 	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
ingest           | 	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
ingest           | 	at java.base/java.lang.Thread.run(Thread.java:834)
ingest           | 
ingest exited with code 1

Startup when Keycloak is already running:

Attaching to ingest
ingest           | exec java -Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager -XX:+ExitOnOutOfMemoryError -cp . -jar /deployments/app.jar
ingest           | __  ____  __  _____   ___  __ ____  ______ 
ingest           |  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ 
ingest           |  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   
ingest           | --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   
ingest           | 2021-02-10 08:44:58,953 INFO  [io.qua.oid.cli.run.OidcClientRecorder] (main) Connecting to IDP for up to 60 times every 2 seconds
ingest           | 2021-02-10 08:44:59,772 INFO  [io.qua.oid.run.OidcRecorder] (main) Connecting to IDP for up to 60 times every 2 seconds
ingest           | 2021-02-10 08:45:00,558 INFO  [com.im.flo.ing.bou.BuildInfoService] (main) ingest V1.0-SNAPSHOT (build at 2021-02-10T09:30:32+0100, commit: 6424ac65bc03a8ae633148bd051ce44825562dc9/6424ac65bc03a8ae633148bd051ce44825562dc9 at 2021-02-10T09:22:52+0100)
ingest           | 2021-02-10 08:45:00,625 INFO  [io.quarkus] (main) ingest 1.0-SNAPSHOT on JVM (powered by Quarkus 1.11.2.Final) started in 3.857s. Listening on: http://0.0.0.0:8091
ingest           | 2021-02-10 08:45:00,626 INFO  [io.quarkus] (main) Profile prod activated. 
ingest           | 2021-02-10 08:45:00,626 INFO  [io.quarkus] (main) Installed features: [cdi, oidc, oidc-client, oidc-client-filter, rest-client, resteasy, resteasy-jsonb, security, smallrye-context-propagation, smallrye-fault-tolerance, smallrye-health, smallrye-metrics, smallrye-openapi, swagger-ui]

To Reproduce

1. Create a project using OIDC client.
   2 Add delay properties quarkus.oidc.connection-delay=120S and quarkus.oidc-client.connection-delay=120S
2. Start App without running Keycloak
3. App instantly crashes.

Configuration

quarkus.oidc.auth-server-url=http://keycloak:8080/auth/realms/flows
quarkus.oidc.client-id=ingest
quarkus.oidc.credentials.secret=b398b8ee-dcb9-4a55-a1ae-eed6c4332406
quarkus.oidc.connection-delay=120S
quarkus.oidc-client.auth-server-url=${quarkus.oidc.auth-server-url}
quarkus.oidc-client.client-id=${quarkus.oidc.client-id}
quarkus.oidc-client.credentials.secret=${quarkus.oidc.credentials.secret}
quarkus.oidc-client.connection-delay=${quarkus.oidc.connection-delay}

Does not work when I use the 120S and not a placeholder.

Environment (please complete the following information):

• Output of java -version: openjdk version "11.0.2" 2019-01-15
• Quarkus version or git rev: 1.11.2-FINAL

[ghost]

/cc @pedroigor, @sberyozkin

[sberyozkin]

Might be a regression caused by Uni based refactoring (i.e I did not update the exception code properly)

[sberyozkin]

@bwand I've removed crashes on startup from the subject - it simply does not reconnect - as opposed to causing a crash. This property has only been added to facilitate the test setups where KC is a few secs or so behind.
I agree it has to be fixed :-)

[bwand]

@sberyozkin Ok it does not reconnect which prevents the app from starting. ;-) We are using docker-compose which starts up everything and even when using depends_on (to keycloak) in docker-compose.yaml we always have some apps not started in first shot and need to manually restart them which is a bit annoying.

So it is fine that you agree it has to be fixed.

[sberyozkin]

Oh I see, it is quarkus-oidc-client which is affected, I thought it was quarkus-oidc hence concluded it may have been a regression.

[bwand]

Yes it is quarkus-oidc-client and not quarkus-oidc.

[steel-judoka]

@sberyozkin can you have a look? I think my pr solves the issue