Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing info in guide discussing Reactive Messaging and HTTP #14551

Closed
gunnarmorling opened this issue Jan 24, 2021 · 6 comments · Fixed by #19675
Closed

Confusing info in guide discussing Reactive Messaging and HTTP #14551

gunnarmorling opened this issue Jan 24, 2021 · 6 comments · Fixed by #19675
Assignees
Milestone

Comments

@gunnarmorling
Copy link
Contributor

In https://quarkus.io/guides/reactive-messaging-http, a few things are confusing:

  • The title mentions WebSockets, whereas this seems not to be the case in the actual contents
  • The "trying it out" part speaks of AMQP, which didn't play a role before
@gunnarmorling gunnarmorling added the kind/bug Something isn't working label Jan 24, 2021
@ghost
Copy link

ghost commented Jan 24, 2021

@gunnarmorling gunnarmorling changed the title Confusing info in guide discussing reactive messaging and httP Confusing info in guide discussing Reactive Messaging and HTTP Jan 24, 2021
@michalszynkiewicz
Copy link
Member

And I see the configuration properties are not listed among all configuration options :(

@michalszynkiewicz
Copy link
Member

I created a PR that removes AMQP and adds some info on the WebSocket connector.
I also added a list of available properties for both connectors.

I'll leave this issue open to create a separate quickstart for websockets and document it in the guide

gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 26, 2021
@cescoffier
Copy link
Member

@michalszynkiewicz any progress around the WebSocket QS?

@cescoffier
Copy link
Member

@michalszynkiewicz did we make any progress on this one?

@michalszynkiewicz
Copy link
Member

nope :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants