Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension to view the values configured by MicroProfile config in development mode #1349

Closed
hpehl opened this issue Mar 8, 2019 · 8 comments
Labels
kind/enhancement New feature or request

Comments

@hpehl
Copy link

hpehl commented Mar 8, 2019

Integrate the config extension into Quarkus. Can come handy in both dev and production mode.

@emmanuelbernard
Copy link
Member

I was thinking of dev mode only actually to avoid some security disaster.

@hpehl
Copy link
Author

hpehl commented Mar 8, 2019

Yes, makes sense to me. We could make it part of the configuration: Default would be enabled in devmode, disabled in production mode.

@emmanuelbernard
Copy link
Member

We hate configuration toggles. They complicate the user experience. You really need an important reason to bring one in. What usage flow would not work if we were not allowing this to be seen in PROD mode?

@hpehl
Copy link
Author

hpehl commented Mar 8, 2019

Agreed, no toggles. I've updated the config extension to only work in development mode:
hpehl/quarkus-config-extension@3530c88

@hpehl hpehl changed the title Add an extension to view the values configured by MicroProfile config Add an extension to view the values configured by MicroProfile config in development mode Mar 8, 2019
@hpehl hpehl changed the title Add an extension to view the values configured by MicroProfile config in development mode Extension to view the values configured by MicroProfile config in development mode Mar 8, 2019
@gsmet gsmet added the kind/enhancement New feature or request label Mar 12, 2019
@gsmet
Copy link
Member

gsmet commented Nov 13, 2019

@hpehl do you plan to do it or should I close it?

@hpehl
Copy link
Author

hpehl commented Nov 14, 2019

I'll update the extension and open a PR.

@stuartwdouglas
Copy link
Member

We can now do this in the config editor in Dev UI, so IMHO this can be closed.

@hpehl
Copy link
Author

hpehl commented Mar 17, 2021

No objections from my side.

@hpehl hpehl closed this as completed Mar 17, 2021
maxandersen added a commit to maxandersen/quarkus that referenced this issue Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants