Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[container-image-docker] Add additional params to docker build command #10966

Closed
j-martinez-dev opened this issue Jul 25, 2020 · 1 comment · Fixed by #10978
Closed

[container-image-docker] Add additional params to docker build command #10966

j-martinez-dev opened this issue Jul 25, 2020 · 1 comment · Fixed by #10978
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@j-martinez-dev
Copy link

Description

It would be helpfull to have the option to configure the build command.

In my enteprise, we use gitlab. And for benefit from the docker layer cache we need to call the command docker build with --cache-from

https://docs.gitlab.com/ee/ci/docker/using_docker_build.html#making-docker-in-docker-builds-faster-with-docker-layer-caching

Implementation ideas

I think that would be great to add :

quarkus.docker.cache-from or quarkus.docker.build (for a more generic solution)

@geoand
Copy link
Contributor

geoand commented Jul 27, 2020

#10978 adds support for --cache-from.

I prefer to add explicit support for flags because it makes it a lot easier for users to see the available options and not end up with an invalid docker build command.

geoand added a commit that referenced this issue Jul 27, 2020
Add support for cache-from in Docker extension
@gsmet gsmet modified the milestones: 1.3.5.Final, 1.7.0 - master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants