Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a RouteHandler per reactive route #10597

Closed
cescoffier opened this issue Jul 9, 2020 · 0 comments · Fixed by #10782
Closed

Generate a RouteHandler per reactive route #10597

cescoffier opened this issue Jul 9, 2020 · 0 comments · Fixed by #10782
Assignees
Labels
area/reactive kind/enhancement New feature or request
Milestone

Comments

@cescoffier
Copy link
Member

Description

At the moment, if you have the following route:

@Route(path="/", produces="application/json")
@Route(path="/foo", produces="text/plain")
public void route(RoutingContext rc) { ...}

We generate a single method handler.
So, during the generation, we can't distinguish if we are producing json or text. By generating multiple methods we can introduce
media-type awareness in the generated bytecode to automatically handle the types. For example we can map objects to json or text automatically.

@cescoffier cescoffier added area/reactive kind/enhancement New feature or request labels Jul 9, 2020
@mkouba mkouba self-assigned this Jul 9, 2020
@mkouba mkouba changed the title Generate a method per reactive route Generate a RouteHandler per reactive route Jul 10, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jul 16, 2020
mkouba added a commit to mkouba/quarkus that referenced this issue Jul 16, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reactive kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants