Random test port stopped working in 1.6.0.Final #10477

arvidvillen · 2020-07-04T15:40:05Z

Describe the bug
Configuring %test.quarkus.http.test-port=0 makes Quarkus start on a free port.
After 1.6.0.Final, tests fail with java.lang.IllegalArgumentException: Port must be greater than 0.

Stacktrace

java.lang.IllegalArgumentException: Port must be greater than 0
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:72)
	at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:105)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:263)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:277)
	at io.restassured.internal.RequestSpecificationImpl.port(RequestSpecificationImpl.groovy:672)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:107)
	at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1262)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1029)
	at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:816)
	at groovy.lang.GroovyObject.invokeMethod(GroovyObject.java:39)
	at org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.call(PogoInterceptableSite.java:45)
	at org.codehaus.groovy.runtime.callsite.PogoInterceptableSite.callCurrent(PogoInterceptableSite.java:55)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:171)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:185)
	at io.restassured.internal.RequestSpecificationImpl.<init>(RequestSpecificationImpl.groovy:145)
	at io.restassured.RestAssured.createTestSpecification(RestAssured.java:1452)
	at io.restassured.RestAssured.given(RestAssured.java:653)
	at org.acme.ExampleResourceTest.testHelloEndpoint(ExampleResourceTest.java:16)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:618)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:526)
	at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
	at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:212)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:208)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1510)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1510)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:248)
	at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$5(DefaultLauncher.java:211)
	at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:226)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:199)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:132)
	at com.intellij.junit5.JUnit5IdeaTestRunner.startRunnerWithArgs(JUnit5IdeaTestRunner.java:71)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:220)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:53)

Expected behavior
The generated port should be propegated to rest-assured correclty.

To Reproduce
Steps to reproduce the behavior:

checkout https://github.com/arvidvillen/quarkus-test-port
mvn package

The text was updated successfully, but these errors were encountered:

rquinio · 2020-07-05T13:52:31Z

Indeed I can reproduce when prefixing with %test, i.e. %test.quarkus.http.test-port=0
In my project I was using quarkus.http.test-port=0 which still works fine.

famod · 2020-07-05T14:41:36Z

FWIW: quarkus.http.test-port set via systemPropertyVariables in surefire-plugin also still works.

arvidvillen · 2020-07-05T18:53:10Z

Thanks for the workaround(s). It would be nice if someone explained what is happening and why it is behaving differently in 1.6.0.Final. If it is a desired behavior (and not a bug), it could possibly be added to the migration guide?

geoand · 2020-07-06T05:30:08Z

It's definitely a bug, I'll need to check it out

geoand · 2020-07-06T05:53:09Z

@radcortez I think this is another incarnation of #9184.
What seems to be happening is that although quarkus.http.test-port is set in a system property, however %test.quarkus.http.test-port is set in application properties with the value of 0 and therefore overrides the system property.

Now this might actually be the correct behavior from a config point of view - if you think it is, I will just make a small change to restore this specific test behavior

Fixes: quarkusio#10477

geoand · 2020-07-06T06:04:01Z

#10488 fixes the problem for the tests

Fixes: quarkusio#10477

radcortez · 2020-07-06T10:01:38Z

@geoand if we follow the rule where a profile property always override a main property no matter the source priority, then yes, this is the correct behaviour.

I'm wondering why in this particular case it was not following that rule.

I also guess that this is one of the cases where @dmlloyd pointed out that once you set a profile property, there is no way to override it in a higher ordinal source, unless you override the profile property itself.

Ensure that %test.quarkus.http.test-port works properly

famod · 2020-07-08T12:12:14Z

@geoand & @radcortez

I just realized that this is also broken for devmode via system property. Does that make sense?

geoand · 2020-07-08T12:14:57Z

Meaning?

famod · 2020-07-08T12:20:06Z

application.yaml:

"%dev":
  quarkus:
    http:
      port: 2081

calling devmode:
mvn quarkus:dev -Dquarkus.http.port=0

will use 2081 instead of a random port.
When I remove the entry from yaml then it works.

I'll create a separate issue.

Edit: #10570

geoand · 2020-07-08T12:31:18Z

Thanks

Fixes: quarkusio#10477

arvidvillen added the kind/bug Something isn't working label Jul 4, 2020

geoand added the area/testing label Jul 4, 2020

geoand added a commit to geoand/quarkus that referenced this issue Jul 6, 2020

Ensure that %test.quarkus.http.test-port works properly

540f4a1

Fixes: quarkusio#10477

geoand mentioned this issue Jul 6, 2020

Ensure that %test.quarkus.http.test-port works properly #10488

Merged

geoand self-assigned this Jul 6, 2020

geoand added a commit to geoand/quarkus that referenced this issue Jul 6, 2020

Ensure that %test.quarkus.http.test-port works properly

e925c3f

Fixes: quarkusio#10477

snowdrop-bot mentioned this issue Jul 6, 2020

Random test port stopped working in 1.6.0.Final snowdrop-zen/quarkus#128

Closed

geoand closed this as completed in #10488 Jul 6, 2020

geoand added a commit that referenced this issue Jul 6, 2020

Merge pull request #10488 from geoand/#10477

9f19c94

Ensure that %test.quarkus.http.test-port works properly

gsmet added this to the 1.6.1.Final milestone Jul 16, 2020

gsmet pushed a commit to gsmet/quarkus that referenced this issue Jul 16, 2020

Ensure that %test.quarkus.http.test-port works properly

583ead4

Fixes: quarkusio#10477

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Random test port stopped working in 1.6.0.Final #10477

Random test port stopped working in 1.6.0.Final #10477

arvidvillen commented Jul 4, 2020 •

edited

Loading

rquinio commented Jul 5, 2020

famod commented Jul 5, 2020

arvidvillen commented Jul 5, 2020

geoand commented Jul 6, 2020

geoand commented Jul 6, 2020

geoand commented Jul 6, 2020 •

edited

Loading

radcortez commented Jul 6, 2020

famod commented Jul 8, 2020

geoand commented Jul 8, 2020

famod commented Jul 8, 2020 •

edited

Loading

geoand commented Jul 8, 2020

Random test port stopped working in 1.6.0.Final #10477

Random test port stopped working in 1.6.0.Final #10477

Comments

arvidvillen commented Jul 4, 2020 • edited Loading

rquinio commented Jul 5, 2020

famod commented Jul 5, 2020

arvidvillen commented Jul 5, 2020

geoand commented Jul 6, 2020

geoand commented Jul 6, 2020

geoand commented Jul 6, 2020 • edited Loading

radcortez commented Jul 6, 2020

famod commented Jul 8, 2020

geoand commented Jul 8, 2020

famod commented Jul 8, 2020 • edited Loading

geoand commented Jul 8, 2020

arvidvillen commented Jul 4, 2020 •

edited

Loading

geoand commented Jul 6, 2020 •

edited

Loading

famod commented Jul 8, 2020 •

edited

Loading